Fix language code validation (PP-422) #1362
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1362 +/- ##
=======================================
Coverage 89.91% 89.92%
=======================================
Files 211 211
Lines 28470 28475 +5
Branches 6498 6499 +1
=======================================
+ Hits 25599 25605 +6
Misses 1880 1880
+ Partials 991 990 -1
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
| @@ -638,12 +638,17 @@ def validate_language_codes( | |||
| ) -> Optional[List[str]]: | |||
| """Verify that collection languages are valid.""" | |||
| if value is not None: | |||
| languages = [] | |||
There was a problem hiding this comment.
Minor: You could switch to a set here to avoid checking before adding a language at l. 652.
There was a problem hiding this comment.
I'm using a list because I want to avoid re-ordering the languages, and sets don't provide order.
There was a problem hiding this comment.
I was thinking about using one of the suggestions from stack overflow for an ordered set, but in the end with this little data, using dict keys to approximate an ordered set seemed to negatively impact readability with very little gain.
Description
The previous validation code was both checking that the language was valid and transforming the language code that gets stored in the database to the three letter version of the code.
When I updated the validation code in #1281, I missed the second part. So we were storing and using the full name of the language. This was causing the libraries lanes not to populate correctly.
Motivation and Context
Support issue PP-422.
In order to fully fix this for libraries that were created after the bug was deployed, but before the fix was deployed we would need a data migration to update the libraries settings and the lane configuration. In a discussion on slack, we decided that since this is only impacting one or two libraries those libraries can be fixed via manual intervention.
For those libraries we will need to:
How Has This Been Tested?
Checklist