Rebase django-saml2-auth to 2.2.1 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We pass the result of `get_current_domain` to pysaml2 to validate the source of the incoming StatusResponse (the scheme+host of the request). This is not viable in a reverse proxy scenario, in particular when the host, port, and/or scheme of the django server changes with churn. As a solution, alter `get_current_domain` to just use a setting variable, `ASSERTION_URL`, instead of the scheme and host of the incoming SAML request. If the setting is not present, use the current behavior.
Add optional ASSERTION_URL setting
Import reverse from django.url for versions >= 2.0
removed local temp file creation
Use Group.set() instead of assignment for Django 2.0 support
unquoting the logout view method reference
…e_proposal adding optional configuration for ADFS SAML compatibility
Allow pysaml2 to be a more recent version.
Allow installation of newer versions of pysaml2 to resolve vulnerabilities
…wt dependency, made the User model come from get_user_model method
…New settings: USE_JWT and FRONTEND_URL. Added django-rest-auth to setup.py
Added new user creation setting.
Added support for local metadata file.
Add JWT Token Support for Single Page Applications through Django Rest Framework
Update README.rst
ae2a315 to
2cce832
Compare
|
@caioariede Could we actually split this up into 2 PRs? One with the rebase and another with the single change for us? That way we can easily track via a PR? |
5dce3b6 to
7914e93
Compare
|
@FabioFleitas updated |
FabioFleitas
approved these changes
Aug 6, 2019
|
|
||
| # Optional settings | ||
| # Optional settings below | ||
| 'DEFAULT_NEXT_URL': '/admin', # Custom target redirect URL after the user get logged in. Default to /admin if not set. This setting will be overwritten if you have parameter ?next= specificed in the login URL. |
There was a problem hiding this comment.
Will we need to update this in our settings?
| # Optional settings | ||
| # Optional settings below | ||
| 'DEFAULT_NEXT_URL': '/admin', # Custom target redirect URL after the user get logged in. Default to /admin if not set. This setting will be overwritten if you have parameter ?next= specificed in the login URL. | ||
| 'CREATE_USER': 'TRUE', # Create a new Django user when a new user logs in. Defaults to True. |
There was a problem hiding this comment.
We will likely want to turn this off in our settings as well right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.