adding optional configuration for ADFS SAML compatibility #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fangli , would you consider merging this pull request?
This is related to the issue #7
I bumped into a few issues getting a compatible integration with ADFS, and added a couple configuration options to allow accommodating ADFS's SAML2 interpretation.
The changes are to add optional settings to pass down to pysaml2 for allowing the addition of the pysaml2
entityid
for authentication requests to populate theIssuer
element, and a change to allow setting (or for ADFS, excluding) theFormat
property on theNameIDPolicy
element via the pysaml2name_id_format
.Also, a change in the setup.py to bump the version of pysaml2 to 4.5.0 to support the option to pass the
name_id_format
.