Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Group.set() instead of assignment for Django 2.0 support #38

Merged
merged 1 commit into from
Jan 29, 2018

Conversation

pintor
Copy link
Contributor

@pintor pintor commented Jan 2, 2018

No description provided.

@CCoffie
Copy link

CCoffie commented Jan 25, 2018

Any idea when these changes might be merged? It would be helpful for those attempting to start Django projects with the latest version(v2.0+).

@fangli
Copy link
Owner

fangli commented Jan 29, 2018

Hi this is really a good PR, I'm currently work on it.
BTW, since this module was used by many organizations and companies( including the one I'm working for), I have to keep the most backward compatibility. and it's a mission-critical module for most systems so I'll add some tests for different django versions.

Thanks all of you.

@fangli fangli merged commit b9072b6 into fangli:master Jan 29, 2018
@CCoffie
Copy link

CCoffie commented Feb 12, 2018

Hey @fangli, Don't mean to rush you or anything but would you happen to know when this will be deployed to pypi?

@ayr-ton
Copy link
Collaborator

ayr-ton commented Mar 3, 2018

@fangli I have the same question than @CCoffie

@bartek
Copy link

bartek commented Mar 14, 2018

Would love to see a release as well! :)

@ayr-ton
Copy link
Collaborator

ayr-ton commented Mar 14, 2018

Just sent an e-mail to @fangli to confirm if he is following this thread.

@fangli
Copy link
Owner

fangli commented Mar 14, 2018

Oh just pushed it to pypi.

@fangli
Copy link
Owner

fangli commented Mar 14, 2018

Frankly speaking if you guys need a super well-maintained saml module I would like to recommand
https://github.com/onelogin/python-saml
to you, which released a few months ago.

I will keep maintaining this project but you know, the python-saml is supported by a company and, that's their bussiness.

Anyway, please feel free to use this one and thanks all of you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants