-
Notifications
You must be signed in to change notification settings - Fork 98
Reimplement base URL support without <base> tag #93
Conversation
Hey, @mattt. Thanks for addressing this. I was going to work on it, but I've been sick for the past two weeks. |
@mattt , CSS also needs to use base-url. Currently it is not working when deployed in non-root folder.
|
Ah, I see, the expectation is to put a single all.css in my root directory? I could do that, but I'm not sure how well it's going to work with my personal workflow. I deploy documentation once per version and then never touch it again. This isn't going to work if all.css file keeps changing with potentially breaking changes to the previously generated documentation. |
That's definitely a bug. Thanks for pointing that out.
The idea is for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't had the chance to try it locally yet, but the rest looks good. 👍
This PR seeks to reimplement base URL support added in #65 based on feedback from #82. With my sincere apologies to @kean for leading him down the wrong path by advocating for
<base>
without being aware of its limitations.I fully acknowledge the jankiness of this approach. Tacking on parameters all over the place like this is unsustainable, but I want to get a fix out sooner rather than later. Long-term, this is the kind of configuration I'd like to encapsulate by a
Generator
(#67)