-
Notifications
You must be signed in to change notification settings - Fork 98
Conversation
Great work, @kean! Thanks so much for taking this on. I pushed a few (small) changes to your PR branch, all to do with naming and documentation. Please take a look at those and let me know if you have any objections to them.
Browsing locally — that is opening As we increase the capabilities of the HTML output, it'll be difficult enough to guarantee common behavior for normal web standards stuff. I'd hate to layer on the additional complexity of handling (That said, we can certainly do more to document how to do this. And, actually, I think this is a perfect opportunity for us to dogfood a "Guide"-style document as discussed in #57. Not a blocker for this, but something to consider as a next step!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once again, great work on this, @kean! The only other change I'd like to request is for you to add an entry to the Changelog. As soon as that's in, we can merge this in 🎉
Thanks, @mattt, I agree with your changes. Updated changelog.
You make a good point, I agree with you. It's not going to be feasibly to keep everything working locally when more features are added. And it's not worthwhile, nobody browses these files locally, probably except me. |
Changelog.md
Outdated
## [Unreleased] | ||
|
||
## TBD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## [Unreleased] | |
## TBD | |
## [Unreleased] |
Thanks for adding that Changelog entry. Just a couple formatting fixes (I was hoping to commit from the suggestions, but that wasn't working for the header deletion) |
No worries, I pushed the updated changelog. |
Alright, merged! Thanks again for your help, @kean 🎉 |
Fixes #56
--base-url
(baseURL: String
) optionbaseUrl
optionUsage:
Notes
I made the minimum number of changes needed to make https://kean-org.github.io/docs/nuke-docs-beta/9.0.0/ work. If you don't think this is the right direction, feel free to close it. I'll keep my workaround locally for now.
What I'm not happy about in this solution is that it is not going to work if you browse it locally. Jazzy uses relative URLs in a form of
<a href="../ImageCaching">
. There are two major advantages. It works regardless of how you deploy it (root or not). And it works locally.