Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Sidebar links are broken in the HTML version #82

Closed
victor-pavlychko opened this issue Apr 13, 2020 · 6 comments
Closed

Sidebar links are broken in the HTML version #82

victor-pavlychko opened this issue Apr 13, 2020 · 6 comments

Comments

@victor-pavlychko
Copy link
Contributor

All sidebar navigational links point to the root document. Looks like this is caused by the <base href="\#(baseURL)"/> element.

@mattt
Copy link
Contributor

mattt commented Apr 13, 2020

Yeah, this is something @kean pointed out in a recent thread (still catching up from the weekend, sorry!)

This behavior of base tags surprised me – I didn’t know about this behavior before. In light of this new information, I think we should consider the alternative approach discussed in #65, which was to factor the base URL into the path helper.

@kean
Copy link
Contributor

kean commented Apr 14, 2020

My bad, I misunderstood how base works. It applies not just to relative URLs, but also anchors https://developer.mozilla.org/en-US/docs/Web/HTML/Element/base.

I use absolute paths on my Jekyll site. It is convenient when this parameter available globally so every page you generate has access to it.

@mattt
Copy link
Contributor

mattt commented Apr 16, 2020

@kean Same here wrt/Jekyll and absolute paths. My suggestion to use a <base> tag was out of left field, and a bad call on my part. The good news is that we haven't released a new version with that yet, so we can make this change without worrying about backwards compatibility.

@dsmurfin
Copy link

I think this is also the same issue in the CommonMark version.

Screenshot 2020-04-22 at 12 29 52

@mattt
Copy link
Contributor

mattt commented Apr 24, 2020

@dsmurfin That is indeed the cause. I'll prioritize a fix for this work to get that out later today.

Edit: See #93

@mattt
Copy link
Contributor

mattt commented May 13, 2020

This is fixed by #93.

@mattt mattt closed this as completed May 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants