fix(DatePicker): onChange callback not being called (carbon-design-sy…

…stem#13774) * fix: onChange callback not being called add undefined as useSavedCallback param type and remove arrow func param * fix(DatePicker): fix code format with prettier --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
SunnyJohal · May 23, 2023 · 13bc1e2 · 13bc1e2
1 parent 3eed2fa
commit 13bc1e2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/packages/react/src/components/DatePicker/DatePicker.tsx b/packages/react/src/components/DatePicker/DatePicker.tsx
@@ -462,10 +462,9 @@ const DatePicker = React.forwardRef(function DatePicker(
     });
   };
 
-  //const savedOnOpen = useSavedCallback(onOpen);
   const endInputField = useRef<HTMLTextAreaElement>(null);
   const calendarRef: any | undefined = useRef(null);
-  const savedOnChange = useSavedCallback(() => onChange);
+  const savedOnChange = useSavedCallback(onChange);
   const savedOnClose = useSavedCallback(
     datePickerType === 'range' ? onCalendarClose : onClose
   );

diff --git a/packages/react/src/internal/useSavedCallback.js b/packages/react/src/internal/useSavedCallback.js
@@ -13,7 +13,7 @@ import { useCallback, useEffect, useRef } from 'react';
  * callback prop but don't want it to be added to the dependency array of an
  * effect.
  *
- * @param {Function} callback
+ * @param {Function | undefined} callback
  * @returns {Function}
  */
 export function useSavedCallback(callback) {