[a11y] Search: Search Icon Label Logic Update (carbon-design-system#1…

…3648)

* [a11y] Search: Search Icon Label Logic Update

With the currently implementation, an accessibility violation occurs when the Search Icon's container doesn't have a role.
The current implementation removes the `role` attribute when the `onExpand` property is undefined, but it should also remove the `aria-labelledby`.

This update will avoid the accessibility violation: https://www.w3.org/TR/wai-aria-1.1/#roles

---

The error can be see in the `@carbon/react` Storybook UI. Visit the [Search component](https://react.carbondesignsystem.com/?path=/story/components-search--default) and click on the 'Accessibility' tab

* fix(tests): snapshots updated after Search a11y update

---------

Co-authored-by: Francine Lucca <40550942+francinelucca@users.noreply.github.com>
Co-authored-by: Alison Joseph <alison.joseph@us.ibm.com>
Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com>

packages/react/src/components/DataTable/__tests__/__snapshots__/DataTable-test.js.snap

@@ -483,7 +483,6 @@ exports[`DataTable behaves as expected selection should render and match snapsho
           role="search"
         >
           <div
-            aria-labelledby="custom-id"
             class="cds--search-magnifier"
           >
             <svg
@@ -886,7 +885,6 @@ exports[`DataTable renders as expected - Component API should render and match s
           role="search"
         >
           <div
-            aria-labelledby="custom-id"
             class="cds--search-magnifier"
           >
             <svg

packages/react/src/components/DataTable/__tests__/__snapshots__/TableToolbarSearch-test.js.snap

@@ -8,7 +8,6 @@ exports[`TableToolbarSearch renders as expected - Component API should render 1`
     role="search"
   >
     <div
-      aria-labelledby="custom-id"
       class="cds--search-magnifier"
     >
       <svg

packages/react/src/components/Search/Search.tsx

@@ -201,7 +201,7 @@ const Search = React.forwardRef<HTMLInputElement, SearchProps>(function Search(
       however, it does not need a keyboard event bc the input element gets focus on keyboard nav and expands that way*/}
       {/* eslint-disable-next-line jsx-a11y/click-events-have-key-events */}
       <div
-        aria-labelledby={uniqueId}
+        aria-labelledby={onExpand ? uniqueId : undefined}
         role={onExpand ? 'button' : undefined}
         className={`${prefix}--search-magnifier`}
         onClick={onExpand}>