fix(DatePicker): onChange callback not being called #13774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add undefined as useSavedCallback param type and remove arrow func param
|
DCO Assistant Lite bot All contributors have signed the DCO. |
|
I have read the DCO document and I hereby sign the DCO. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@kaiodealmeida I think you just need to run |
It's done! |
tw15egan
approved these changes
May 11, 2023
dabrad26
approved these changes
May 11, 2023
tay1orjones
approved these changes
May 12, 2023
tay1orjones
pushed a commit
to tay1orjones/carbon
that referenced
this pull request
May 12, 2023
…stem#13774) * fix: onChange callback not being called add undefined as useSavedCallback param type and remove arrow func param * fix(DatePicker): fix code format with prettier --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Closed
|
|
SunnyJohal
pushed a commit
to SunnyJohal/carbon
that referenced
this pull request
May 23, 2023
…stem#13774) * fix: onChange callback not being called add undefined as useSavedCallback param type and remove arrow func param * fix(DatePicker): fix code format with prettier --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13726
Changelog
Changed
Testing / Reviewing
Chromatic Deploy