Update default value of constrain media setting

[kmeleta]

PR Summary:

Changes the default value of the Constrain media to screen height setting.

Important: Could cause a visual change in existing themes for some users depending on product image sizes.

Why are these changes introduced?

Relates to #2052

The constrain setting was originally included with the default set to false. Which would prevent any visual changes. However, we intend for the setting to be true moving forward so this PR just changes that default value.

We originally considered a softer rollout of this change, where we update the setting default in a subsequent release, but adding the desired end state now as a breaking change for a major release comes with less logistical overhead.

What approach did you take?

Updated default setting in the main-product and featured-product section schemas and also added the missing default in the product.json template.

Visual impact on existing themes

This is a visually breaking change.

Depending on the selected media width setting, the aspect ratio of the product images, and the end user's viewport dimensions, it is possible some product images will be scaled down to fit within the viewport. This will be most common with taller portrait images on relatively shorter viewports. Otherwise the effect of this change might not be immediately noticeable.

Before:

After:

Testing steps/scenarios

• Ensure constrain setting is checked and applied by default on the product page
• Ensure constrain setting is checked and applied by default when adding new featured product sections

Demo links

• Editor

Checklist

• Added PR summary for release notes
• Requested review from UX (Only for changes that are affecting the experience or perceivable visual details)
• Created a ticket for the help.shopify.com documentation team about updates to theme settings. (Internal-only task)
• Followed theme code principles
• Linted with Theme Check
• Tested on mobile
• Tested on multiple browsers
• Tested for accessibility

[melissaperreault]

Thanks Ken! Looks good!
It's definitely an improvement for keeping tall images shorter on larger screens and for normalizing the height when all media have different ratio. 🚢 🚢 When they do manual update, merchants can always uncheck this to revert to what they had.

[andrewetchen]

• Ensure constrain setting is checked and applied by default on the product page
• Ensure constrain setting is checked and applied by default when adding new featured product sections

This looks good to me!

Thanks for adding the "Settings change" label and for adding the "constrain_to_viewport" setting to the product.json template. All other themes already have this so we'll just need to update the values etc. 🙌🏼

[kmeleta]

All other themes already have this so we'll just need to update the values etc. 🙌🏼

Oh.. yeah I forgot we did that already.. Oh well.