Skip to content

Commit

Permalink
Update default value of constrain media setting (Shopify#2266)
Browse files Browse the repository at this point in the history
* Update constrain default for main and featured product

* Add missing default to product template
  • Loading branch information
kmeleta authored Jan 30, 2023
1 parent ae2c3b7 commit 8516e89
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion sections/featured-product.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -1379,7 +1379,7 @@
{
"type": "checkbox",
"id": "constrain_to_viewport",
"default": false,
"default": true,
"label": "t:sections.main-product.settings.constrain_to_viewport.label"
},
{
Expand Down
6 changes: 3 additions & 3 deletions sections/main-product.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@
</span>
{% render 'icon-plus' %}
</button>
</quantity-input>
</quantity-input>
<div class="quantity__rules caption">
{%- if product.selected_or_first_available_variant.quantity_rule.increment > 1 -%}
<span class="divider">
Expand All @@ -279,7 +279,7 @@
| t: quantity: product.selected_or_first_available_variant.quantity_rule.max
-}}
</span>
{%- endif -%}
{%- endif -%}
</div>
</div>
{%- when 'popup' -%}
Expand Down Expand Up @@ -1929,7 +1929,7 @@
{
"type": "checkbox",
"id": "constrain_to_viewport",
"default": false,
"default": true,
"label": "t:sections.main-product.settings.constrain_to_viewport.label"
},
{
Expand Down
1 change: 1 addition & 0 deletions templates/product.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@
"enable_sticky_info": true,
"gallery_layout": "stacked",
"media_size": "large",
"constrain_to_viewport": true,
"mobile_thumbnails": "hide",
"hide_variants": true,
"enable_video_looping": false,
Expand Down

0 comments on commit 8516e89

Please sign in to comment.