-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add total_duties to customer account order page #1368
Add total_duties to customer account order page #1368
Conversation
3c421e1
to
8ddab10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just awaiting translations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks Minh.
I'll approve again once all translations come back.
d18a554
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Unrelated, At checkout, I was wondering why we see Taxes
prior to Duties
, it was interesting to witness. (Video reference)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Minh, looks like a bunch of files were modified by an app on your store and sent back as commits on your branch. Would you mind reverting those two commits from your shop? Once that's done, I'll re-approve. Thanks!
40d44c7
to
d18a554
Compare
@martinamarien Hey Martina, thanks for letting me know. I have removed the 2 commits from the branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just re-tested everything. Seems good to me.
Thanks for adding this Minh.
Why are these changes introduced?
What approach did you take?
total_duties
is an attribute on order object, I used this attribute to display the total duties. In cases where duties are not applicable (merchants do not collect duties, or the order is domestic), the duties line is not rendered.Here's an example of duties being rendered
Testing steps/scenarios
Enable the duties and taxes incoterm feature. Set up shipping to an international country. In taxes and duties setting page, collect duties in that international country. Sign up / Log into an account. Checkout.
Demo links
Please include a link to a demo store that includes preconfigured sections and settings to allow reviewers to easily test the features you are working on.
Checklist