Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display duties correctly for Cancelled orders #2109

Open
rockeynebhwani opened this issue Nov 8, 2022 · 0 comments
Open

Display duties correctly for Cancelled orders #2109

rockeynebhwani opened this issue Nov 8, 2022 · 0 comments

Comments

@rockeynebhwani
Copy link

rockeynebhwani commented Nov 8, 2022

Describe the current behavior
Dawn theme doesn't display duties correctly for a Cancelled order in My account and in Cancellation email. Changes to show duties were made as part of #1368 by @minh-tran-shopify but looks like this change didn't consider Cancelled order scenario.

This is how it looks in cancellation email. Totals don't sum up because duty component is missing -

Screenshot 2022-11-08 at 19 31 49

This is how it looks in my account because we are using 'order.total_duties' and this is always 0 if order is cancelled.

Screenshot 2022-11-08 at 19 28 00

Describe the expected behavior

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 5.0.0

Possible solution
Updated Cancellation Emails and my account order history display to show duty component so that order totals add up and make sense for the customer.

I can't find anything on order object which gives details of duty component when order is cancelled. This may required changes by Shopify first.

Additional context/screenshots
Add any other context about the problem here. If applicable, add screenshots to help explain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant