Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type parameters to AutoSparseFiniteDiff #35

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Add type parameters to AutoSparseFiniteDiff #35

merged 1 commit into from
Apr 3, 2024

Conversation

gdalle
Copy link
Collaborator

@gdalle gdalle commented Apr 3, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Fixes #33

@gdalle gdalle requested a review from Vaibhavdixit02 April 3, 2024 06:07
@Vaibhavdixit02 Vaibhavdixit02 merged commit 93b8c6c into main Apr 3, 2024
4 checks passed
@Vaibhavdixit02 Vaibhavdixit02 deleted the gd/finitediff_types branch April 3, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vaibhavdixit02 Vaibhavdixit02 Awaiting requested review from Vaibhavdixit02

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Give AutoSparseFiniteDiff the same type parameters as AutoFiniteDiff
2 participants
@gdalle @Vaibhavdixit02