Merge pull request #35 from SciML/gd/finitediff_types

Add type parameters to AutoSparseFiniteDiff
SciML · Apr 3, 2024 · 93b8c6c · 93b8c6c
2 parents 8d50cb9 + 67e8f7b
commit 93b8c6c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/ADTypes.jl b/src/ADTypes.jl
@@ -168,7 +168,11 @@ end
 
 Chooses [FiniteDiff.jl](https://github.com/JuliaDiff/FiniteDiff.jl) while exploiting sparsity.
 """
-struct AutoSparseFiniteDiff <: AbstractSparseFiniteDifferences end
+Base.@kwdef struct AutoSparseFiniteDiff{T1, T2, T3} <: AbstractSparseFiniteDifferences
+    fdtype::T1 = Val(:forward)
+    fdjtype::T2 = fdtype
+    fdhtype::T3 = Val(:hcentral)
+end
 
 """
     AutoSparseForwardDiff{chunksize,T}

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -77,6 +77,9 @@ struct CustomTag end
     adtype = AutoSparseFiniteDiff()
     @test adtype isa ADTypes.AbstractADType
     @test adtype isa AutoSparseFiniteDiff
+    @test adtype.fdtype === Val(:forward)
+    @test adtype.fdjtype === Val(:forward)
+    @test adtype.fdhtype === Val(:hcentral)
 
     adtype = AutoSparseForwardDiff()
     @test adtype isa ADTypes.AbstractADType