Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give AutoSparseFiniteDiff the same type parameters as AutoFiniteDiff #33

Closed
gdalle opened this issue Mar 29, 2024 · 6 comments · Fixed by #35
Closed

Give AutoSparseFiniteDiff the same type parameters as AutoFiniteDiff #33

gdalle opened this issue Mar 29, 2024 · 6 comments · Fixed by #35
Labels
enhancement New feature or request

Comments

@gdalle
Copy link
Collaborator

gdalle commented Mar 29, 2024

Is there a reason why AutoFiniteDiff specifies the finite difference mode and AutoSparseFiniteDiff doesn't?
@gdalle gdalle added the enhancement New feature or request label Mar 29, 2024
@ChrisRackauckas
Copy link
Member

Just oversight.

@gdalle
Copy link
Collaborator Author

gdalle commented Mar 31, 2024

would this be considered a breaking change to add them, given that everything is documented now?

@ChrisRackauckas
Copy link
Member

No, adding arguments with defaults wouldn't be breaking.

@gdalle
Copy link
Collaborator Author

gdalle commented Mar 31, 2024

But adding a type parameter might be?
https://discourse.julialang.org/t/is-adding-a-type-parameter-to-a-struct-a-breaking-change/111236

@ChrisRackauckas
Copy link
Member

it is not. There is no code that would dispatch differently if you added a type parameter there.

@gdalle
Copy link
Collaborator Author

gdalle commented Mar 31, 2024

fair enough. I'll open a PR

@gdalle gdalle mentioned this issue Apr 3, 2024
Merged
5 tasks
This was referenced Apr 10, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add type parameters to AutoSparseFiniteDiff SciML/ADTypes.jl
2 participants
@ChrisRackauckas @gdalle