Csharp run on net8 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* C#: Fail CI on warnings. * Fix found warnings.
* Node: Allow chaining function calls on transaction. This allows a builder-like pattern of calls, which is a bit more readable. * fixes
* up c# syntax, make cli defaults in one style * add .editorconfig --------- Co-authored-by: Guriy Samarin <guriy@amazon.com> Co-authored-by: Shachar Langbeheim <nihohit@gmail.com>
…#916) * Java: Refactor command_manager and remove command Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update commandmanager to remove optional<route> argument Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Updates for review comments Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
* Java: Update ClusterValue javadocs Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Java: Update ClusterValue javadocs Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Java: Update ClusterValue javadocs Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
* Java: Add PING command Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Remove unnecessary handlers Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Remove OK string Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Clean up import Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Spotless Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Add @nonnull annotation Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Ping documentation update Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Add sharedtests to IT Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Fix IT Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Use genertic response handler Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update handleRedisResponse Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Use @timeout annotation Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Remove unnecessary nonnull Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Allow for null response in customCommand Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
* Update commandmanager to remove optional<route> argument Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Java: Add GET & SET commands Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Move IT tests to SharedCommandTests Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Spotless Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Add nonnull check to API Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Fix from merge Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update handleRedisResponse Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Use @timeout annotation Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Remove extra @nonnull annotations Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Merge main Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Add NonNull Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Add back IT tests Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Remove extra tests Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Add DELME tests Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Minor: clean tests; throw exception Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
* Parameterize Python tests for both RESP2 & RESP3. * use split parameters
------------ Co-authored-by: Adan Wattad <adanwat@amazon.com>
* Update commandmanager to remove optional<route> argument Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Java: Add Info commands to client Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Clean tests Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Fix build.gradle Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update to merge easier Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Spotless Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update javadoc for info clustered Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
* Java: Add transaction commands Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com> * Clean up for review comments Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com> * Fix CommandManagerTest.java Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com> * All transactions require an argument (empty is fine) Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com> * Add IT tests for transactions Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com> * Renaming field Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Add IT tests for Transactions Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update exec() command with route Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update exec() command with route Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Remove failing tests Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Spotless Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Spotless Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Spotless Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update cluster comments Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrewc@bitquilltech.com> Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.