up c# syntax, make cli defaults in one style #903
Conversation
|
Added .editorconfig. I can also add |
|
please do add linting in the C# CI - style changes should be accompanied by a linter that will catch such style violations in the future. |
* C#: Fail CI on warnings. * Fix found warnings.
.editorconfig
Outdated
| tab_width = 4 | ||
|
|
||
| # New line preferences | ||
| end_of_line = crlf |
There was a problem hiding this comment.
why not lf? Are you changing all files to lf or crlf?
There was a problem hiding this comment.
I have no preferences. Making it lf
.editorconfig
Outdated
|
|
||
| # New line preferences | ||
| end_of_line = crlf | ||
| insert_final_newline = false |
There was a problem hiding this comment.
conflicts with line 6. Please keep true there.
There was a problem hiding this comment.
It is not conflict - it is just specific settings for cs. Changing to true
|
@Yury-Fridlyand any further comments? |
|
@Sa1Gur we'd love to know whether you're planning on advancing the C# prototype and move towards a full working wrapper, or whether you were just interested in fixing the existing code. |
|
Yes, I'm planning to advanced C# prototype. |
Updating c# syntax
Making defaults for CommandLineOptions in one style (using attribute parameter Default)