Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix license script #913

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix license script #913

merged 1 commit into from
Feb 7, 2024

Conversation

shohamazon
Copy link
Collaborator

Issue #, if available:

after #912 python tests failure

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shohamazon shohamazon requested a review from a team as a code owner February 7, 2024 14:33
@nihohit
Copy link
Contributor

nihohit commented Feb 7, 2024

@shohamazon have you ran this locally through the CI, to verify it fixes everything?

@shohamazon
Copy link
Collaborator Author

@shohamazon have you ran this locally through the CI, to verify it fixes everything?

yes,

black ../utils/get_licenses_from_ort.py 
  All done! ✨ 🍰 ✨
  1 file left unchanged.
mypy ../utils/get_licenses_from_ort.py 
  Success: no issues found in 1 source file

@shohamazon shohamazon merged commit 5f0f13d into valkey-io:main Feb 7, 2024
@shohamazon shohamazon deleted the fix_license_script branch February 7, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shachlanAmazon shachlanAmazon shachlanAmazon approved these changes

@barshaul barshaul Awaiting requested review from barshaul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shohamazon @nihohit @shachlanAmazon