Support BetterReflection 4

[Jean85]

Fixes #234, includes #247

[Ocramius]

7.3 should probably be removed from the build

…

On Fri, Jun 19, 2020, 21:53 Alessandro Lai ***@***.***> wrote: Fixes #234 <#234>, includes #247 <#247> ------------------------------ You can view, comment on, or merge this pull request online at: #248 Commit Summary - Fix Psalm errors - Fix Travis warnings - Allow BetterReflection 4 File Changes - *M* .travis.yml <https://github.com/Roave/BackwardCompatibilityCheck/pull/248/files#diff-354f30a63fb0907d4ad57269548329e3> (4) - *M* composer.json <https://github.com/Roave/BackwardCompatibilityCheck/pull/248/files#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780> (2) - *M* composer.lock <https://github.com/Roave/BackwardCompatibilityCheck/pull/248/files#diff-1da2c7edc898c70e5a79a9997c98cecc> (152) - *M* src/LocateDependencies/LocateDependenciesViaComposer.php <https://github.com/Roave/BackwardCompatibilityCheck/pull/248/files#diff-aead2e6dd2a72a4d1417870ed3f6c040> (3) - *M* test/unit/DetectChanges/BCBreak/ClassConstantBased/ClassConstantValueChangedTest.php <https://github.com/Roave/BackwardCompatibilityCheck/pull/248/files#diff-fb9ce5cc70d97fd8d9ab0625d79d2da3> (2) - *M* test/unit/DetectChanges/BCBreak/ClassConstantBased/ClassConstantVisibilityReducedTest.php <https://github.com/Roave/BackwardCompatibilityCheck/pull/248/files#diff-09309640be224628abb65577a9a2d091> (2) - *M* test/unit/StringReflectorFactory.php <https://github.com/Roave/BackwardCompatibilityCheck/pull/248/files#diff-476e7223666abf83acb1122152128cec> (6) Patch Links: - https://github.com/Roave/BackwardCompatibilityCheck/pull/248.patch - https://github.com/Roave/BackwardCompatibilityCheck/pull/248.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#248>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABFVEHW6RRL355ZRPZVEXLRXO64VANCNFSM4OC76CFA> .

[Jean85]

7.3 should probably be removed from the build

Why?

BTW rebased on top of green build in #247, now this should be green too.

[Ocramius]

If this is green, it can go in as-is 👍

[Ocramius]

I think we should only keep BetterReflection 4.6+ here: that's what the mutation tests seem to also pick up here (although I don't see the mutant from my phone)

[Jean85]

--show-mutants is missing in CI, I'll add it:

Escaped mutants:
================


1) /home/alai/workspace/OSS/BackwardCompatibilityCheck/src/DetectChanges/BCBreak/PropertyBased/PropertyDocumentedTypeChanged.php:39    [M] UnwrapArrayUnique

--- Original
+++ New
@@ @@
             return Changes::empty();
         }
         try {
-            $fromTypes = array_unique($fromProperty->getDocBlockTypeStrings());
+            $fromTypes = $fromProperty->getDocBlockTypeStrings();
             $toTypes = array_unique($toProperty->getDocBlockTypeStrings());
         } catch (InvalidArgumentException $failedToParseDocblock) {
             // @TODO #134 improve docblock parsing upstream to remove this generic try-catch


2) /home/alai/workspace/OSS/BackwardCompatibilityCheck/src/DetectChanges/BCBreak/PropertyBased/PropertyDocumentedTypeChanged.php:40    [M] UnwrapArrayUnique

--- Original
+++ New
@@ @@
         }
         try {
             $fromTypes = array_unique($fromProperty->getDocBlockTypeStrings());
-            $toTypes = array_unique($toProperty->getDocBlockTypeStrings());
+            $toTypes = $toProperty->getDocBlockTypeStrings();
         } catch (InvalidArgumentException $failedToParseDocblock) {
             // @TODO #134 improve docblock parsing upstream to remove this generic try-catch
             return Changes::empty();

I'll try to fix them...

[EDIT] It seems that the uniqueness applied to those arrays is already done by BetterReflection, is it right? Is it possible to ignore those mutants?

[Ocramius]

These should likely have tests, not be unwrapped...

[Ocramius]

It seems that the uniqueness applied to those arrays is already done by BetterReflection, is it right? Is it possible to ignore those mutants?

If the uniqueness isn't needed, then it should likely be removed: mutation testing works both ways, finding unused code or untested code :-)

[Jean85]

Ok 👍 Since I don't know at which point that mutant will start appearing, I bumped BetterReflection to 4.3, which seems to be the latest minor supporting 7.3, and it doesn't mutate.

[Ocramius]

Excellent! \o/

Thanks @Jean85, you basically did what I was supposed to do :D