Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BetterReflection 4 #248

Merged
merged 13 commits into from
Jun 22, 2020
Merged

Support BetterReflection 4 #248

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
64cf190
Fix Psalm errors
Jean85 Jun 19, 2020
e849c6a
Fix Travis warnings
Jean85 Jun 19, 2020
5ebad01
Fix CS trying not to break SCA
Jean85 Jun 19, 2020
ddb95e5
Allow BetterReflection 4
Jean85 Jun 19, 2020
c804c2c
Fix CS
Jean85 Jun 19, 2020
aa30370
Fix composer.lock to update under 7.3
Jean85 Jun 19, 2020
c4938de
Add --show-mutations to Infection in CI
Jean85 Jun 20, 2020
2938ecc
Ignore 2 specific mutations due to BC change in BetterReflection
Jean85 Jun 20, 2020
e8fb085
Revert "Ignore 2 specific mutations due to BC change in BetterReflect…
Jean85 Jun 22, 2020
36742c5
Bump BetterReflection to ^4.3
Jean85 Jun 22, 2020
4528996
Fix the mutant
Jean85 Jun 22, 2020
af2e6a7
Remove unused try-catch
Jean85 Jun 22, 2020
24c4fe7
Fix CS
Jean85 Jun 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ git:

deploy:
provider: releases
api_key: $DEPLOY_TOKEN_SECURE
token: $DEPLOY_TOKEN_SECURE
file: dist/roave-backward-compatibility-check.phar
# do not skip cleanup: if the repo is cleaned up when deploying, then the phar is gone as well.
skip_cleanup: true
cleanup: false
on:
tags: true

Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"composer/composer": "^1.10.5",
"nikolaposa/version": "^4.0.0",
"ocramius/package-versions": "^1.5.1",
"roave/better-reflection": "^3.5.0",
"roave/better-reflection": "^3.5.0 || ^4.0.0",
"symfony/console": "^4.4.8",
"symfony/process": "^5.1.0",
"thecodingmachine/safe": "^1.1"
Expand Down
149 changes: 76 additions & 73 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions src/Changes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,6 @@ public function getIterator() : iterable
$this->unBufferedChanges = null;
}

/**
* {@inheritDoc}
*/
public function count() : int
{
return count(iterator_to_array($this));
Expand Down
5 changes: 0 additions & 5 deletions src/CompareClasses.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,6 @@ public function __construct(
$this->traitBasedComparisons = $traitBasedComparisons;
}

/**
* {@inheritDoc}
*/
public function __invoke(
ClassReflector $definedSymbols,
ClassReflector $pastSourcesWithDependencies,
Expand Down Expand Up @@ -75,7 +72,6 @@ private function makeSymbolsIterator(
ClassReflector $newSourcesWithDependencies
) : iterable {
foreach ($definedApiClassNames as $apiClassName) {
/** @var ReflectionClass $oldSymbol */
$oldSymbol = $pastSourcesWithDependencies->reflect($apiClassName);

yield from $this->examineSymbol($oldSymbol, $newSourcesWithDependencies);
Expand All @@ -87,7 +83,6 @@ private function examineSymbol(
ClassReflector $newSourcesWithDependencies
) : Generator {
try {
/** @var ReflectionClass $newClass */
$newClass = $newSourcesWithDependencies->reflect($oldSymbol->getName());
} catch (IdentifierNotFound $exception) {
yield Change::removed(sprintf('Class %s has been deleted', $oldSymbol->getName()), true);
Expand Down
Loading