Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build #247

Merged
merged 3 commits into from
Jun 19, 2020
Merged

Fix build #247

merged 3 commits into from
Jun 19, 2020

Conversation

Jean85
Copy link
Contributor

@Jean85 Jean85 commented Jun 19, 2020

This should make the build green.

Travis config edits are meant to silence config warnings: https://travis-ci.org/github/Roave/BackwardCompatibilityCheck/builds/696432282/config

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build still failing though 😬🤔

.travis.yml Show resolved Hide resolved
@Jean85
Copy link
Contributor Author

Jean85 commented Jun 19, 2020

Fixed now, I hope. CS automatic fixes were clashing with SCA so I had to do a few iterations; good news is that SCA got better and I just had to get rid of a couple of type annotations.

@Ocramius Ocramius added the bug label Jun 19, 2020
@Ocramius Ocramius added this to the 5.0.0 milestone Jun 19, 2020
@Ocramius Ocramius self-assigned this Jun 19, 2020
@Jean85 Jean85 requested a review from Ocramius June 19, 2020 20:24
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks! 👍

@Ocramius Ocramius merged commit 927b5ae into Roave:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants