Refactor loadModelRuns to the store as a global action #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
There was a problem hiding this comment.
This makes sense to me, and it works without any issues. I'll defer to @BryonLewis for approval since this is a clientside-only change
Comment on lines
+286
to
+291
| await ApiService.getObservationImages(id, data); | ||
| // Notify the ModelRunList that downloading is happening | ||
| if (imageDownloadingModelRunId.value) { | ||
| emit('image-download', imageDownloadingModelRunId.value); | ||
| } | ||
| refreshModelRunDownloadingStatuses(); |
There was a problem hiding this comment.
I assume this was autoformatted. I'll file an issue to investigate why the linting step didn't flag this the first time around
There was a problem hiding this comment.
I think the linting step isn't performing as intended when I run npm run lint:fix, but I haven't looked into it yet.
- Rename loadModelRuns to queryModelRuns - Rename checkDownloading to refreshModelRunDownloadingStatuses
6c3c887 to
962407c
Compare
BryonLewis
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loadModelRunsis now part of the store asqueryModelRunsand updates store state.queryModelRunsmanages pagination state through "firstPage" and "nextPage" requests (see ModelRunList.vue for usage).checkDownloadingis now part of the store asrefreshModelRunDownloadingStatuses. Additionally, it has been fixed to properly update the downloading statuses of all loaded pagination pages.state.downloadCheckhave been replaced with calls torefreshModelRunDownloadingStatuses.