Support uploading model runs from the web client #490
Conversation
3cb8427 to
092e1ff
Compare
|
@BryonLewis is there an existing notion of a private/public model run in RD-WATCH?
|
e6eb50b to
b9475c8
Compare
97bc05b to
91de8e0
Compare
| @@ -719,3 +724,99 @@ def download_sam_model_if_not_exists(**kwargs): | |||
| return f'Error downloading file: {e}' | |||
| else: | |||
| return f'File already exists at {file_path}' | |||
|
|
|||
There was a problem hiding this comment.
After going through the animation export I think we should probably move some of these into their own file. In the future we should break up the __init__.py at least into an image downloading file (there are a lot of functions that handle that.).
f651981 to
03635c8
Compare
|
Recent updates:
|
There was a problem hiding this comment.
Sorry I've been a bit busy on other projects but got around to review this. Some of the comments are generic things that could be implemented in the future. The main things are:
- The Region override not working properly
- I think it would be good to get the modelrun list to refresh on upload task completion.
The section about allowing multiple uploads to be processed at once and having the dialog be non-blocking isn't as important now considering modelruns should be processed in a few seconds.
| </v-card-actions> | ||
| </v-card> | ||
| </v-dialog> | ||
| <v-dialog v-model="successDialog" persistent width="25%"> |
There was a problem hiding this comment.
In regards to this being persistent.
Not a huge issue because I know the infrastructure to properly handle it would be annoying. I'm wondering if something that is dependent on a celery worker being in an available state and running the task should block access to the rest of the application while it's processing.
When I'm talking about infrastructure I mean that if we have userId tied to the upload and the task we could add another endpoint in the views model_run for listing all currently active upload tasks for a user. The user could then see the progress of those tasks. To know they are currently doing something. This gives the extra benefit of not needing to block user input on fields while an upload is processing. Allowing for a user to upload a zip file and while it is processing upload another zip file with no delay. These are just thoughts right now and probably don't need to be implemented for this PR.
03635c8 to
a4e4264
Compare
Also adds more restricted conditions for overriding
8121089 to
46358e6
Compare
Co-authored-by: Mike VanDenburgh <37340715+mvandenburgh@users.noreply.github.com>
Add support for uploading model runs from the web client.
This draft PR gets the end-to-end pipeline of uploading and processing a zip file of geojsons. There are a couple of extra things to do to complete this PR.
The core pipeline can use an initial review pass.
Screenshots:
