set timeMin to modelRun list timeMin #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does the same change need to happen to |
It was sitting in my commit list in VSCode (I guess I forgot to click on commit all). Thanks, |
floryst
approved these changes
Sep 13, 2024
floryst
added a commit
that referenced
this pull request
Sep 13, 2024
* Refactor loadModelRuns out of ModelRunList.vue - Rename loadModelRuns to queryModelRuns - Rename checkDownloading to refreshModelRunDownloadingStatuses * Call refreshModelRunDownloadingStatuses directly * set timeMin to modelRun list timeMin (#506) --------- Co-authored-by: Bryon Lewis <61746913+BryonLewis@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removal of the
@update:timeRangfromSideBar.vuemeant that the slider was always going to utilize the UNIX epoch time. This uses the globalstate.timeMin. I think this was an oversight of mine when I was converting the very heavily integrated component system signaling (where it was doing some passing up/down of information) into more of a store system when I came on to the project.I do understand that our Store is really overloaded right now and at some point should probably be refactored but that is an issue for another time.