Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Datasource bootsource property #1601

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Add Datasource bootsource property #1601

merged 2 commits into from
Jan 25, 2024

Conversation

hmeir
Copy link
Contributor

@hmeir hmeir commented Jan 22, 2024

Short description

Adding boot source proprety to DataSource class.
Accessing it returns PVC / Volumesnapshot boot source - the one the the Datasource is pointing to.

More details:

Also added deprecation message on 'pvc' property, starting from 4.16.

What this PR does / why we need it:

Datasource has only pvc property - now it can access snapshot as well.

@redhat-qe-bot1
Copy link

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
Supported /retest check runs
  • /retest tox: Retest tox
  • /retest python-module-install: Retest python-module-install
Supported labels
  • hold
  • verified
  • wip
  • lgtm

Signed-off-by: Harel Meir <hmeir@redhat.com>
Signed-off-by: Harel Meir <hmeir@redhat.com>
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hmeir
Copy link
Contributor Author

hmeir commented Jan 25, 2024

/verified

@myakove myakove merged commit 16fa5d4 into RedHatQE:main Jan 25, 2024
7 checks passed
@hmeir
Copy link
Contributor Author

hmeir commented Jan 25, 2024

/cherry-pick v4.15

@redhat-qe-bot
Copy link
Contributor

Manual cherry-pick is needed
Cherry pick failed for 16fa5d4 to v4.15:
To cherry-pick run:

git remote update
git checkout v4.15
git pull origin v4.15
git checkout -b datasource-snapshot-prop-v4.15
git cherry-pick 16fa5d4412fc69d62466fdf8dc81e5edf0013323
git push origin datasource-snapshot-prop-v4.15

myakove pushed a commit that referenced this pull request Jan 29, 2024
* Add snapshot property to Datasource class



* Add deprecation warning for DataSource pvc property



---------

Signed-off-by: Harel Meir <hmeir@redhat.com>
Co-authored-by: Ruth Netser <rnetser@redhat.com>
myakove pushed a commit that referenced this pull request Jan 30, 2024
* Add snapshot property to Datasource class

* Add deprecation warning for DataSource pvc property

---------

Signed-off-by: Harel Meir <hmeir@redhat.com>
Co-authored-by: Ruth Netser <rnetser@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants