Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Datasource bootsource property (#1601) (#1621) #1628

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Add Datasource bootsource property (#1601) (#1621) #1628

merged 1 commit into from
Jan 30, 2024

Conversation

hmeir
Copy link
Contributor

@hmeir hmeir commented Jan 29, 2024

  • Add snapshot property to Datasource class

  • Add deprecation warning for DataSource pvc property

@redhat-qe-bot1
Copy link

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
Supported /retest check runs
  • /retest tox: Retest tox
  • /retest python-module-install: Retest python-module-install
Supported labels
  • hold
  • verified
  • wip
  • lgtm

* Add snapshot property to Datasource class

* Add deprecation warning for DataSource pvc property

---------

Signed-off-by: Harel Meir <hmeir@redhat.com>
Co-authored-by: Ruth Netser <rnetser@redhat.com>
Signed-off-by: Harel Meir <hmeir@redhat.com>
auto-merge was automatically disabled January 30, 2024 09:11

Head branch was pushed to by a user without write access

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@myakove myakove enabled auto-merge (squash) January 30, 2024 09:22
@hmeir
Copy link
Contributor Author

hmeir commented Jan 30, 2024

/verified

@myakove myakove merged commit 71ea5e9 into RedHatQE:v4.14 Jan 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants