Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix source setting KeyError: 'spec' in to_dict() method #1631

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

vsibirsk
Copy link
Contributor

@vsibirsk vsibirsk commented Feb 1, 2024

Short description:

Fix the issue in DataSource to_dict() method when setting source value in self.res if self.res doesn't have any spec

Which issue(s) this PR fixes:

Fixes issue introduced in #1601

@redhat-qe-bot
Copy link
Contributor

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
Supported /retest check runs
  • /retest tox: Retest tox
  • /retest python-module-install: Retest python-module-install
Supported labels
  • hold
  • verified
  • wip
  • lgtm

Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vsibirsk
Copy link
Contributor Author

vsibirsk commented Feb 1, 2024

/verified

@myakove
Copy link
Collaborator

myakove commented Feb 1, 2024

can you please fill the missing parts in the first comment @vsibirsk ?

@myakove myakove changed the title fix source setting in to_dict() method fix source setting KeyError: 'spec' in to_dict() method Feb 1, 2024
@myakove
Copy link
Collaborator

myakove commented Feb 1, 2024

/lgtm

@myakove myakove enabled auto-merge (squash) February 1, 2024 14:22
@myakove myakove merged commit 1660c60 into RedHatQE:main Feb 1, 2024
7 checks passed
@vsibirsk vsibirsk deleted the fix-datasource-to-dict branch February 1, 2024 14:22
@vsibirsk
Copy link
Contributor Author

vsibirsk commented Feb 1, 2024

/cherry-pick v4.15

@redhat-qe-bot1
Copy link

Cherry-picked PR fix source setting KeyError: 'spec' in to_dict() method into v4.15

@vsibirsk
Copy link
Contributor Author

vsibirsk commented Feb 1, 2024

/cherry-pick v4.14

@redhat-qe-bot1
Copy link

Cherry-picked PR fix source setting KeyError: 'spec' in to_dict() method into v4.14

redhat-qe-bot1 added a commit that referenced this pull request Feb 1, 2024
Co-authored-by: vsibirsk <57763370+vsibirsk@users.noreply.github.com>
redhat-qe-bot1 added a commit that referenced this pull request Feb 1, 2024
Co-authored-by: vsibirsk <57763370+vsibirsk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants