Strengthen CRAN_Release.cmd to find UBSAN errors in data.table.Rcheck #5509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| isTRUE(.Machine$sizeof.longdouble==0) # check noLD is being tested | ||
| options(repos = "http://cloud.r-project.org") | ||
| install.packages(c("bit64","xts","nanotime","R.utils","yaml")) # minimum packages needed to not skip any tests in test.data.table() | ||
| # install.packages(c("curl","knitr")) # for `R CMD check` when not strict. Too slow to install when strict | ||
| install.packages(c("bit64", "bit", "curl", "R.utils", "xts","nanotime", "zoo", "yaml", "knitr", "rmarkdown")) |
There was a problem hiding this comment.
maybe set Ncpus if this is really so slow?
There was a problem hiding this comment.
It's not so slow anymore. Didn't time it but under 30 mins I think. Could be that clang's ubsan is faster than gcc's perhaps. I tended to use gcc in the past. Anyway, Ncpus is a good idea, should use it regardless.
mattdowle
added a commit
that referenced
this pull request
Nov 2, 2022
ben-schwen
added a commit
that referenced
this pull request
Dec 21, 2023
MichaelChirico
added a commit
that referenced
this pull request
Dec 22, 2023
* add multiple containers add symlinks add RUN use echo to create .Rprofile add workdir symlink + echo add dependencies for check add char vec update echo update dockerfile fix FROM update dirs use rocker image rollback to jans clang image change docker order change flags update makevars update flags add workdir change C version clang working rm local .Rprofile * tidy spaces * update flags to #5509 * Robust deps install, use files over echo, tidy * no ARG * Wrong context? * need to COPY DESCRIPTION. Try more WORKDIR. * attempt to fix Makevars, .Rprofile * Try copying .Rprofile to /root. Remove ~/GitHub for now. * same changes to gcc container * Try adding REdtiorSupport extension by default * load cc conditionally * Don't install languageserver by default (slow) * udpate image and makevars * drop native * terminal newline * whitespace * whitespace --------- Co-authored-by: Michael Chirico <michaelchirico4@gmail.com> Co-authored-by: Michael Chirico <chiricom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5496
Made many attempts to capture UBSAN errors on stderr but nothing worked. sink()-ing type="message" does work but the UBSAN errors still appeared in the output rather than the sink'd file. Also tried a Linux only
stat /proc/self/fd/2before and after the test to see if the timestamp of stderr had increased, with no luck. SettingUBSAN_OPTIONS=log_path=....is possible but seems too UBSAN specific; I was hoping to capture anything on stderr to include ASAN too for example and any other tool that might arise in future.So in the end, just strengthened CRAN_Release.cmd to do a full
R CMD checkunder UBSAN/ASAN rather than just test.data.table(). So now .Rd examples and vignettes are covered too. And included agrepon data.table.Rcheck/*.Rout for the UBSAN errors. Can refine it in future.