-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UBSAN runtime errors #5510
Comments
|
HughParsonage
added a commit
that referenced
this issue
Dec 17, 2023
Note that some double -> integer64 conversions are collapsed into the one warning, affecting tests, so these have been updated.
HughParsonage
added a commit
that referenced
this issue
Dec 17, 2023
Merged
MichaelChirico
added a commit
that referenced
this issue
Dec 26, 2023
* Fix UB via int conversion (#5510) Note that some double -> integer64 conversions are collapsed into the one warning, affecting tests, so these have been updated. * Ensure nan is not coerced. Closes #5510 * Fix '1' mistakenly removed from earlier commit * Re #5834 * Rename function more sensibly * Incorporate finite checks into the logic * Suspend int64 coerce tests subject to #5834 * Update CODEOWNERS * Revert CODEOWNERS * Update CODEOWNERS With extant file endings * Simplify logic for integer check * Check for NA_INTEGER superfluous * Test 6.53 should emit warning on -2^31 * C++ toolkit included by default * first pass at fix * Simplify/unite with within_int64_repres() * weak inequality --------- Co-authored-by: Michael Chirico <chiricom@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Ran dev through full
Rdevel-strict-clang CMD check
added in #5509I'll need to run again but using
test.data.table()
to get the test numbers ...The text was updated successfully, but these errors were encountered: