Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account Service SIWF v2 URI Validation #640

Closed
wilwade opened this issue Oct 22, 2024 · 0 comments · Fixed by #669
Closed

Account Service SIWF v2 URI Validation #640

wilwade opened this issue Oct 22, 2024 · 0 comments · Fixed by #669
Assignees
@mattheworris

Comments

@wilwade
Copy link
Contributor

wilwade commented Oct 22, 2024

Related: ProjectLibertyLabs/siwf#200

Instead of validating just the domain, we should validate the URI. All of the examples should still work from the above issue.
@mattheworris mattheworris linked a pull request Oct 31, 2024 that will close this issue
Account Service SIWF v2 URI Validation #669
Merged
@mattheworris mattheworris mentioned this issue Oct 31, 2024
Merged
mattheworris added a commit that referenced this issue Nov 1, 2024
@mattheworris
Account Service SIWF v2 URI Validation (#669)
f1818cf 
# Problem

Updates to support siwf v2.1.0

Closes #640 

# Solution

- Renamed `SIWF_V2_DOMAIN` to `SIWF_V2_URI_VALIDATION` and follow on
config changes, tests, etc.
- Renamed `loginMsgDomain` to `loginMsgURIValidation`
- Updated `ENVIRONMENT.md`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattheworris mattheworris

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Account Service SIWF v2 URI Validation ProjectLibertyLabs/gateway
2 participants
@wilwade @mattheworris