We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If an application is using a custom scheme (such as for a desktop or mobile application), then just validation of the login domain is not enough.
The Library should instead, validate the URI using this set of rules:
Fix: https://github.com/ProjectLibertyLabs/siwf/blob/main/libraries/js/src/mocks/payloads.ts#L16 should use a passed in URI instead of a static value.
Should Work Examples:
https://www.example.com/login
https
www.example.com
/login
example://login
example
login
www.example.com/login
localhost:3030/login/path
localhost
/login/path
The text was updated successfully, but these errors were encountered:
Bug: Domain only validation doesn't work for custom schemes (#205)
ce36a68
# Problem Closes #200
mattheworris
Successfully merging a pull request may close this issue.
If an application is using a custom scheme (such as for a desktop or mobile application), then just validation of the login domain is not enough.
The Library should instead, validate the URI using this set of rules:
Fix: https://github.com/ProjectLibertyLabs/siwf/blob/main/libraries/js/src/mocks/payloads.ts#L16 should use a passed in URI instead of a static value.
Should Work Examples:
https://www.example.com/login
Validatehttps
,www.example.com
and/login
example://login
Validateexample
,login
, and Ignore pathwww.example.com/login
Validatewww.example.com
and/login
and Ignore schemelocalhost:3030/login/path
Validatelocalhost
domain and/login/path
path. Ignore the portThe text was updated successfully, but these errors were encountered: