Account Service SIWF v2 URI Validation #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in account configmap
enddynayn
reviewed
Nov 1, 2024
| expect(accountServiceConfig.siwfV2Url).toStrictEqual(ALL_ENV.SIWF_V2_URL); | ||
| }); | ||
|
|
||
| it.each([['https://example.com/login'], ['example://login'], ['localhost'], ['localhost:3030/login/path']])( |
mattheworris
commented
Nov 1, 2024
| @@ -41,12 +41,6 @@ describe('Account API Config', () => { | |||
| it('invalid api timeout limit should fail', async () => shouldFailBadValues(ALL_ENV, 'API_TIMEOUT_MS', [0])); | |||
|
|
|||
| it('invalid url for SIWF_V2_URL', async () => shouldFailBadValues(ALL_ENV, 'SIWF_V2_URL', ['sdfdsf'])); | |||
|
|
|||
| it('invalid url SIWF_V2_DOMAIN', async () => | |||
| shouldFailBadValues(ALL_ENV, 'SIWF_V2_DOMAIN', ['https://www.example.com'])); | |||
There was a problem hiding this comment.
These values are valid now.
mattheworris
commented
Nov 1, 2024
| @@ -18,7 +18,8 @@ data: | |||
| HEALTH_CHECK_SUCCESS_THRESHOLD: {{ .Values.account.env.HEALTH_CHECK_SUCCESS_THRESHOLD | quote }} | |||
| CAPACITY_LIMIT: {{ .Values.account.env.CAPACITY_LIMIT | quote }} | |||
| SIWF_URL: {{ .Values.account.env.SIWF_URL | quote }} | |||
| SIWF_DOMAIN: {{ .Values.account.env.SIWF_DOMAIN | quote }} | |||
| SIWF_V2_URL: {{ .Values.account.env.SIWF_V2_URL | quote }} | |||
There was a problem hiding this comment.
@saraswatpuneet This value is optional, is it okay to put it or will it cause errors if it is not set?
wilwade
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Updates to support siwf v2.1.0
Closes #640
Solution
SIWF_V2_DOMAINtoSIWF_V2_URI_VALIDATIONand follow on config changes, tests, etc.loginMsgDomaintologinMsgURIValidationENVIRONMENT.md