Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(apps): rename plugins to apps #9755

Merged
merged 4 commits into from
May 20, 2022
Merged

chore(apps): rename plugins to apps #9755

merged 4 commits into from
May 20, 2022

Conversation

mariusandra
Copy link
Collaborator

Problem

Changes

  • Renames "Plugin" and "Plugins" to "App" and "Apps" on all the plugin app pages.
  • Does not rename Plugin to App everywhere in the code. The Scene is still called Plugin, etc. We can do this as the next step.

2022-05-12 13 17 03

Not done

  • We refer to the "repository" now as the "App Library" in some places and as the repository in others. What should it be?
  • I didn't change any of the links. They all still lead to pages like posthog.com/plugins . Where should all the blue links visible in the screencast lead to?

How did you test this code?

  • Clicked around locally

@mariusandra mariusandra mentioned this pull request May 12, 2022
Closed
@joethreepwood
Copy link
Contributor

As per PostHog/posthog.com#3253 the place to see all available apps will be /apps so we should probably be directing users there, or to specific pages in that folder.

Also on that PR I think I've correctly redirected the /plugins and /integrations pages on .com to the new /apps page. However, I think extra work from @smallbrownbike or @corywatilo may be warranted there to make that new /apps page easier to use. There's no search or filters currently, for example. But I defer to them.

I'd love to get a solution to #9509 too, so that we can link from /apps to the Apps section of the product, but that may be a later job.

@joethreepwood joethreepwood mentioned this pull request May 12, 2022
Merged
@joethreepwood
Copy link
Contributor

joethreepwood commented May 12, 2022 •
edited
Loading

I think this looks good to me, based on my many years of coding experience.

Just needs to sync with PostHog/posthog.com#3253

Does not rename Plugin to App everywhere in the code.

This is consistent with changes I made to the docs as part of the above PR. I've changed references to the plugin server to the app server, but haven't touched any code samples (and have referenced plugin/app server in cases where it seemed important to encompass ambiguity).

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@joethreepwood
Copy link
Contributor

@mariusandra We're good to launch this whenever you're ready. They're already called apps on the website now.

@mariusandra mariusandra merged commit 6a5a71b into master May 20, 2022
@mariusandra mariusandra deleted the rename-plugins branch May 20, 2022 14:16
@mariusandra
Copy link
Collaborator Author

And it's done! 🎉

fuziontech added a commit that referenced this pull request May 20, 2022
@fuziontech
Merge branch 'master' into 22.3
7212f0d 
* master:
  chore: start stack once in cloud tests (#9879)
  feat(apps): frontend apps (#9831)
  chore: Fix snapshots on master (#9885)
  chore(apps): rename plugins to apps (#9755)
  refactor: Remove constance library dependency, use json-encoded model (#9852)
  chore(clickhouse): avoid creating kafka_events, events_mv (#9863)
  fix(insights): Fix timezone date issues (#9678)
  refactor(plugin-server): refactor the event pipeline (#9829)
  feat(object storage): add unused object storage (#9846)
  fix: make kafka health check timeout test reliable (#9857)
  fix: query elements from start of day (#9827)
alexkim205 pushed a commit that referenced this pull request May 23, 2022
@mariusandra @alexkim205
chore(apps): rename plugins to apps (#9755)
643f229 
* chore(apps): rename plugins to apps

* rename more

* few more links and lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joethreepwood joethreepwood joethreepwood approved these changes

@pauldambra pauldambra Awaiting requested review from pauldambra

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariusandra @joethreepwood @posthog-bot