Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hackathon: Nail ~plugin docs~ apps #3253

Merged
merged 134 commits into from
May 13, 2022
Merged

hackathon: Nail ~plugin docs~ apps #3253

merged 134 commits into from
May 13, 2022

Conversation

jamesefhawkins
Copy link
Contributor

Changes

Nails plugin docs

corywatilo and others added 30 commits March 30, 2022 09:54
@joethreepwood
Copy link
Contributor

This should be content complete now, in most major ways. It's a very big PR which:

  • Gives each app a product page
  • Gives each app a separate docs page
  • Updates all docs and content to (mostly) refer to plugins as apps

Parallel to this I've already made changes to the contribution guidelines, so that new apps will be contributed with better documentation. Tutorials, which were previously a part of this PR, have already been split out and released too.

Following discussion in PostHog/posthog#9654 I've removed the built-in apps (funnels, trends) from the scope of this and left them as product features. However, there may be additional tidying up here for the Website team based on on-going product page work and apps directory work.

We should also sync deployment of this with the change of plugins to apps in the product and the release of Emanuele's new apps.

However, most of the words are now in and all the content actions from the initial checklist are also handled.

Milestone reached. Open to feedback.

smallbrownbike and others added 8 commits May 12, 2022 07:47
* update app template

* add filters

* source apps

* add filters

* add build your own tile

* filter scroll

* Fix typos

* specifying # built-in products vs 3rd party apps

Co-authored-by: PostHog <hey@posthog.com>
Co-authored-by: Cory Watilo <corywatilo@gmail.com>
@corywatilo
Copy link
Collaborator

corywatilo commented May 13, 2022

@smallbrownbike I reverted 6ee8cfb as it was throwing an error on a fresh build. (We didn't notice because it wouldn't happen until a new build was triggered.)

internal/modules/cjs/loader.js:1089
      throw new ERR_REQUIRE_ESM(filename, parentPath, packageJsonPath);
      ^

Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: /Users/cw/working/posthog.com/node_modules/gatsby-recipes/node_modules/remark-mdx/index.js
require() of ES modules is not supported.
require() of /Users/cw/working/posthog.com/node_modules/gatsby-recipes/node_modules/remark-mdx/index.js from
/Users/cw/working/posthog.com/node_modules/gatsby-recipes/dist/graphql-server/server.js is an ES module file as it is a .js file whose nearest parent package.json contains
"type": "module" which defines all .js files in that package scope as ES modules.
Instead rename index.js to end in .cjs, change the requiring code to use import(), or remove "type": "module" from
/Users/cw/working/posthog.com/node_modules/gatsby-recipes/node_modules/remark-mdx/package.json.

from build logs:

7:09:07 PM: error "gatsby-node.js" threw an error while running the createPages lifecycle:
7:09:07 PM: Syntax Error: Expected Name, found )
7:09:07 PM: 
7:09:07 PM: 
7:09:07 PM:   GraphQLError: Syntax Error: Expected Name, found )
7:09:07 PM: 
7:09:07 PM: failed createPages - 0.025s

Edit: Since we're keeping product pages inside /product, I realized we can just move the mdx files back into the /product directory since they're the same as what were moved into /apps so this commit isn't needed anymore. Safe to ignore!

@corywatilo corywatilo linked an issue May 13, 2022 that may be closed by this pull request
23 tasks
Copy link
Collaborator

@corywatilo corywatilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yolo

@corywatilo corywatilo merged commit b3ee5cc into master May 13, 2022
@corywatilo corywatilo deleted the apps-everywhere branch May 13, 2022 18:14
corywatilo added a commit that referenced this pull request May 13, 2022
* list apps on homepage (wip)

* update menu, create hubspot page as example

* adds app store block to homepage

* updated menu structure

* updated homepage hero messaging

* integrated documentation with the main hubspot page

* created hubspot tutorials

* modernizing hero while still using older "product analytics" language

* urls for apps

* fix the thing

* polish

* like grammar

* created a bunch of app pages

* Update index.mdx

* Update index.mdx

* Update index.mdx

* tons more apps added

* Update index.mdx

* Update index.mdx

* bigquery export done

* Update index.mdx

* added s3 and did a little tidying

* Update index.mdx

* Update index.mdx

* added redshift and snowflake

* Fix typos

* Update index.mdx

* created salesforce connector docs

* creates /apps page, moves apps logos into component

* geoip docs

* messaging updates to product page

* pagerduty doc

* docs

* final bits

* adding built-in apps to apps list

* tutorials core

* tutorial images

* banners for tuts

* yet more pages made

* list out all built-in apps with icons

* created more things

* ALL THE APPS

* tweak

* move /product/feature-name to /apps/app-name

* more directory changes (product → apps)

* redirects and updating links

* Add safe redirects (JS)

* Big documentation format update

* Added free button (badly lol)

* tidying up a few bits

* Hitting all the data warehouses with some new copy

* More plugin info

* more apps

* More apps

* another app

* Gosh I feel ill

* cough cough very ill rn

* fixed syntax

* Fix typos

* lots more apps

* Fix typos

* more apps

* did somebody say...APPS?

* deez apps

* are we done?

* Fix typos

* Done. For now. Also, sidebars.

* typo

* Adding contributor attribution and source code

* Fix typos

* Added requirements for all apps

* Dozens of consistency tweaks

* Consistency tweaks to every page

* Visual tweaks

* Consistency and content polish

* Final pass of product page polish

* Fixing something from a new plugin update

* Update index.mdx

* Removing tutorials

* remove

* Updating all array, case studies and blog posts with plugins to apps

Excl. the state of plugins post, for impact and SEO reasons.

* Update plugins to apps

This doesn't update URLs, code segments and some specific pieces which would seem to have technical impact. It is limited to all docs body copy.

* Handbook changes

* Big doc update

* Renaming the apps section. Hopefully redirect will kick in?

* Logos, adding final apps, updating applist

* Docs for emanueles new apps

* Redirects and menu fixes

* Removing built-in apps from home and /apps

* Remove built-in apps from the /product page

* Timeline: plugins to apps

* Amazon Kinesis app

* Last app descriptions

* Making braze app beta

* minor correction to url for twilio

* Apps everywhere cleanup (#3425)

* update app template

* add filters

* source apps

* add filters

* add build your own tile

* filter scroll

* Fix typos

* specifying # built-in products vs 3rd party apps

Co-authored-by: PostHog <hey@posthog.com>
Co-authored-by: Cory Watilo <corywatilo@gmail.com>

* Add safe redirects (JS)

* Vendasta case study plugin reference

* hide built in apps

* general cleanup

* 50-ish tho

* more this and that

* change references from plugins and integrations to apps

* partial revert

* move product pages back into /product from /apps

* restore product subpage nav

* add product page template

* byo min height

* splat redirects

* extend hover color

* renaming a bunch of things from plugins/integrations to apps

* fixing a few final references from integrations → apps

Co-authored-by: Cory Watilo <corywatilo@gmail.com>
Co-authored-by: Joe Martin <84011561+joethreepwood@users.noreply.github.com>
Co-authored-by: PostHog <hey@posthog.com>
Co-authored-by: Eli Kinsey <eli@ekinsey.dev>
smallbrownbike added a commit that referenced this pull request May 13, 2022
* update references to apps on pricing page

* Add safe redirects (JS)

* hackathon: Nail ~plugin docs~ apps (#3253)

* list apps on homepage (wip)

* update menu, create hubspot page as example

* adds app store block to homepage

* updated menu structure

* updated homepage hero messaging

* integrated documentation with the main hubspot page

* created hubspot tutorials

* modernizing hero while still using older "product analytics" language

* urls for apps

* fix the thing

* polish

* like grammar

* created a bunch of app pages

* Update index.mdx

* Update index.mdx

* Update index.mdx

* tons more apps added

* Update index.mdx

* Update index.mdx

* bigquery export done

* Update index.mdx

* added s3 and did a little tidying

* Update index.mdx

* Update index.mdx

* added redshift and snowflake

* Fix typos

* Update index.mdx

* created salesforce connector docs

* creates /apps page, moves apps logos into component

* geoip docs

* messaging updates to product page

* pagerduty doc

* docs

* final bits

* adding built-in apps to apps list

* tutorials core

* tutorial images

* banners for tuts

* yet more pages made

* list out all built-in apps with icons

* created more things

* ALL THE APPS

* tweak

* move /product/feature-name to /apps/app-name

* more directory changes (product → apps)

* redirects and updating links

* Add safe redirects (JS)

* Big documentation format update

* Added free button (badly lol)

* tidying up a few bits

* Hitting all the data warehouses with some new copy

* More plugin info

* more apps

* More apps

* another app

* Gosh I feel ill

* cough cough very ill rn

* fixed syntax

* Fix typos

* lots more apps

* Fix typos

* more apps

* did somebody say...APPS?

* deez apps

* are we done?

* Fix typos

* Done. For now. Also, sidebars.

* typo

* Adding contributor attribution and source code

* Fix typos

* Added requirements for all apps

* Dozens of consistency tweaks

* Consistency tweaks to every page

* Visual tweaks

* Consistency and content polish

* Final pass of product page polish

* Fixing something from a new plugin update

* Update index.mdx

* Removing tutorials

* remove

* Updating all array, case studies and blog posts with plugins to apps

Excl. the state of plugins post, for impact and SEO reasons.

* Update plugins to apps

This doesn't update URLs, code segments and some specific pieces which would seem to have technical impact. It is limited to all docs body copy.

* Handbook changes

* Big doc update

* Renaming the apps section. Hopefully redirect will kick in?

* Logos, adding final apps, updating applist

* Docs for emanueles new apps

* Redirects and menu fixes

* Removing built-in apps from home and /apps

* Remove built-in apps from the /product page

* Timeline: plugins to apps

* Amazon Kinesis app

* Last app descriptions

* Making braze app beta

* minor correction to url for twilio

* Apps everywhere cleanup (#3425)

* update app template

* add filters

* source apps

* add filters

* add build your own tile

* filter scroll

* Fix typos

* specifying # built-in products vs 3rd party apps

Co-authored-by: PostHog <hey@posthog.com>
Co-authored-by: Cory Watilo <corywatilo@gmail.com>

* Add safe redirects (JS)

* Vendasta case study plugin reference

* hide built in apps

* general cleanup

* 50-ish tho

* more this and that

* change references from plugins and integrations to apps

* partial revert

* move product pages back into /product from /apps

* restore product subpage nav

* add product page template

* byo min height

* splat redirects

* extend hover color

* renaming a bunch of things from plugins/integrations to apps

* fixing a few final references from integrations → apps

Co-authored-by: Cory Watilo <corywatilo@gmail.com>
Co-authored-by: Joe Martin <84011561+joethreepwood@users.noreply.github.com>
Co-authored-by: PostHog <hey@posthog.com>
Co-authored-by: Eli Kinsey <eli@ekinsey.dev>

* maybe don't use development fonts in prod 🙄

Co-authored-by: Cory Watilo <corywatilo@gmail.com>
Co-authored-by: PostHog <hey@posthog.com>
Co-authored-by: James Hawkins <47497682+jamesefhawkins@users.noreply.github.com>
Co-authored-by: Joe Martin <84011561+joethreepwood@users.noreply.github.com>
Co-authored-by: Eli Kinsey <eli@ekinsey.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EPIC] Nail Plugins
4 participants