Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(apps): rename plugins to apps #9755

Merged
merged 4 commits into from
May 20, 2022
+71 −73
Merged

chore(apps): rename plugins to apps #9755

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
73be7c1
chore(apps): rename plugins to apps
mariusandra May 12, 2022
4a4cb39
Merge branch 'master' into rename-plugins
mariusandra May 20, 2022
3f49a69
rename more
mariusandra May 20, 2022
7a0607c
few more links and lines
mariusandra May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/layout/navigation/SideBar/SideBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ function Pages(): JSX.Element {
<PageButton icon={<IconComment />} identifier={Scene.Annotations} to={urls.annotations()} />
<LemonDivider />
{canViewPlugins(currentOrganization) && (
<PageButton icon={<IconExtension />} identifier={Scene.Plugins} to={urls.plugins()} />
<PageButton icon={<IconExtension />} identifier={Scene.Plugins} to={urls.projectApps()} />
)}
<PageButton icon={<IconTools />} identifier={Scene.ToolbarLaunch} to={urls.toolbarLaunch()} />
<PageButton
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/lib/components/CommandPalette/commandPaletteLogic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@ export const commandPaletteLogic = kea<
display: 'Go to Plugins',
synonyms: ['integrations'],
executor: () => {
push(urls.plugins())
push(urls.projectApps())
},
},
{
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/lib/components/UniversalSearch/UniversalSearchPopup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ function redirectOnSelectItems(
router.actions.push(urls.experiment(value))
} else if (groupType === TaxonomicFilterGroupType.Plugins) {
router.actions.push(
combineUrl(urls.plugins(), {
combineUrl(urls.projectApps(), {
tab: (item as PluginSelectionType).tab,
name: (item as PluginSelectionType).name,
}).url
Expand Down
8 changes: 4 additions & 4 deletions frontend/src/scenes/plugins/Plugins.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@ export function Plugins(): JSX.Element | null {
return (
<div className="plugins-scene">
<PageHeader
title="Plugins"
title="Apps"
caption={
<>
Plugins enable you to extend PostHog's core data processing functionality.
Apps enable you to extend PostHog's core data processing functionality.
<br />
Make use of verified plugins from the{' '}
Make use of verified apps from the{' '}
<a href="https://posthog.com/plugins" target="_blank">
Plugin Library
App Library
</a>{' '}
– or{' '}
<a href="https://posthog.com/docs/plugins/build" target="_blank">
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/scenes/plugins/PluginsSearch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export function PluginsSearch(): JSX.Element {
return (
<Input.Search
data-attr="plugins-search"
placeholder="Start typing to search for a plugin"
placeholder="Start typing to search for an app"
autoFocus
value={searchTerm || ''}
onChange={(e) => setSearchTerm(e.target.value)}
Expand Down
12 changes: 6 additions & 6 deletions frontend/src/scenes/plugins/edit/PluginDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ export function PluginDrawer(): JSX.Element {
canInstallPlugins(user?.organization, editingPlugin.organization_id) && (
<Popconfirm
placement="topLeft"
title="Are you sure you wish to uninstall this plugin completely?"
title="Are you sure you wish to uninstall this app completely?"
onConfirm={() => uninstallPlugin(editingPlugin.name)}
okText="Uninstall"
cancelText="Cancel"
Expand All @@ -168,8 +168,8 @@ export function PluginDrawer(): JSX.Element {
<Tooltip
title={
<>
This plugin can currently be used by other organizations in this
instance of PostHog. This action will <b>disable and hide it</b> for all
This app can currently be used by other organizations in this instance
of PostHog. This action will <b>disable and hide it</b> for all
organizations other than yours.
</>
}
Expand All @@ -187,8 +187,8 @@ export function PluginDrawer(): JSX.Element {
<Tooltip
title={
<>
This action will mark this plugin as installed for{' '}
<b>all organizations</b> in this instance of PostHog.
This action will mark this app as installed for <b>all organizations</b>{' '}
in this instance of PostHog.
</>
}
>
Expand Down Expand Up @@ -307,7 +307,7 @@ export function PluginDrawer(): JSX.Element {
Configuration
</h3>
{getConfigSchemaArray(editingPlugin.config_schema).length === 0 ? (
<div>This plugin is not configurable.</div>
<div>This app is not configurable.</div>
) : null}
{getConfigSchemaArray(editingPlugin.config_schema).map((fieldConfig, index) => (
<React.Fragment key={fieldConfig.key || `__key__${index}`}>
Expand Down
10 changes: 5 additions & 5 deletions frontend/src/scenes/plugins/edit/PluginSource.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,14 +88,14 @@ export function PluginSource(): JSX.Element | null {
visible={editingSource}
onClose={() => {
if (form.getFieldValue('source') !== editingPlugin?.source) {
confirm('You have unsaved changes in your plugin. Are you sure you want to exit?') &&
confirm('You have unsaved changes in your app. Are you sure you want to exit?') &&
setEditingSource(false)
} else {
setEditingSource(false)
}
}}
width={'min(90vw, 64rem)'}
title={`Coding Plugin: ${editingPlugin?.name}`}
title={`Coding App: ${editingPlugin?.name}`}
placement="left"
footer={
<div style={{ textAlign: 'right' }}>
Expand All @@ -114,16 +114,16 @@ export function PluginSource(): JSX.Element | null {
<p>
Read our{' '}
<a href="https://posthog.com/docs/plugins/build/overview" target="_blank">
plugin building overview in PostHog Docs
app building overview in PostHog Docs
</a>{' '}
for a good grasp of possibilities.
<br />
Once satisfied with your plugin, feel free to{' '}
Once satisfied with your app, feel free to{' '}
<a
href="https://posthog.com/docs/plugins/build/tutorial#submitting-your-plugin"
target="_blank"
>
submit it to the official Plugin Library
submit it to the official App Library
</a>
.
</p>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/scenes/plugins/edit/interface-jobs/PluginJobOptions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export function PluginJobOptions({ plugin, pluginConfigId }: PluginJobOptionsPro
return (
<div key={jobName}>
{jobName === 'Export historical events' ? (
<Tooltip title="Run this plugin on all historical events ingested until now">
<Tooltip title="Run this app on all historical events ingested until now">
<i>Export historical events</i>
</Tooltip>
) : (
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/scenes/plugins/plugin/CommunityPluginTag.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ export function CommunityPluginTag({ isCommunity }: { isCommunity?: boolean }):
<Tooltip
title={
isCommunity
? 'This plugin was built by a community memeber, not the PostHog team.'
: 'This plugin was built by the PostHog team.'
? 'This app was built by a community memeber, not the PostHog team.'
: 'This app was built by the PostHog team.'
}
>
<Tag color={isCommunity ? 'cyan' : 'geekblue'}>{isCommunity ? 'Community' : 'Official'}</Tag>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/scenes/plugins/plugin/LocalPluginTag.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export function LocalPluginTag({
return (
<Tooltip title={url.substring(5)}>
<Tag color="purple" onClick={() => copyToClipboard(url.substring(5))} style={style}>
{title || 'Local Plugin'}
{title || 'Local App'}
</Tag>
</Tooltip>
)
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/scenes/plugins/plugin/LogsDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export function LogsDrawer(): JSX.Element {
visible={!!showingLogsPlugin}
onClose={hidePluginLogs}
width={'min(90vw, 80rem)'}
title={`Viewing Plugin Logs: ${lastShownLogsPlugin?.name}`}
title={`Viewing App Logs: ${lastShownLogsPlugin?.name}`}
placement="left"
destroyOnClose
>
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/scenes/plugins/plugin/PluginCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export function PluginCard({
</DragColumn>
) : null}
{unorderedPlugin ? (
<Tooltip title="This plugin does not do any processing in order." placement="topRight">
<Tooltip title="This app does not do any processing in order." placement="topRight">
<Col>
<Tag color="#555">-</Tag>
</Col>
Expand Down Expand Up @@ -204,7 +204,7 @@ export function PluginCard({
title={
pluginConfig?.id
? 'Logs'
: 'Logs – enable the plugin for the first time to view them'
: 'Logs – enable the app for the first time to view them'
}
>
<Button
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/scenes/plugins/tabs/advanced/AdvancedTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,16 @@ export function AdvancedTab(): JSX.Element {
message="Advanced Features Ahead"
description={
<>
Create and install your <b>own plugins</b> or plugins from <b>third-parties</b>. If you're
looking for officially supported plugins, try the{' '}
Create and install your <b>own apps</b> or apps from <b>third-parties</b>. If you're looking for
officially supported apps, try the{' '}
<a
href="#"
onClick={(e) => {
e.preventDefault()
setPluginTab(PluginTab.Repository)
}}
>
Plugin Repository
App Repository
</a>
.
</>
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/scenes/plugins/tabs/advanced/CustomPlugin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export function CustomPlugin(): JSX.Element {
<Card>
<Title level={5}>Install from GitHub, GitLab or npm</Title>
<Paragraph>
To install a third-party or custom plugin, paste its URL below. For{' '}
To install a third-party or custom app, paste its URL below. For{' '}
<a
href="https://docs.github.com/en/github/authenticating-to-github/creating-a-personal-access-token"
target="_blank"
Expand All @@ -41,7 +41,7 @@ export function CustomPlugin(): JSX.Element {
</a>{' '}
private repositories, append <code>?private_token=TOKEN</code> to the end of the URL.
<br />
<b className="text-warning">Warning: Only install plugins from trusted sources.</b>
<b className="text-warning">Warning: Only install apps from trusted sources.</b>
</Paragraph>

<Row style={{ width: '100%' }} gutter={16}>
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/scenes/plugins/tabs/advanced/LocalPlugin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ export function LocalPlugin(): JSX.Element {
return (
<div style={{ marginTop: 16 }}>
<Card>
<Title level={5}>Install Local Plugin</Title>
<Paragraph>To install a local plugin from this computer/server, give its full path below.</Paragraph>
<Title level={5}>Install Local App</Title>
<Paragraph>To install a local app from this computer/server, give its full path below.</Paragraph>

<Row style={{ width: '100%' }} gutter={16}>
<Col style={{ flex: 1 }}>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/scenes/plugins/tabs/advanced/SourcePlugin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export function SourcePlugin(): JSX.Element {
value={sourcePluginName}
disabled={loading}
onChange={(e) => setSourcePluginName(e.target.value)}
placeholder={`For example: "Hourly Weather Sync Plugin"`}
placeholder={`For example: "Hourly Weather Sync App"`}
/>
</Col>
<Col>
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/scenes/plugins/tabs/installed/sections/DisabledPluginsSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export function DisabledPluginSection(): JSX.Element {
) : (
<CaretRightOutlined />
)}
{` Installed plugins (${filteredDisabledPlugins.length})`}
{` Installed apps (${filteredDisabledPlugins.length})`}
</>
}
/>
Expand All @@ -42,7 +42,7 @@ export function DisabledPluginSection(): JSX.Element {
))}
</Row>
) : (
<p style={{ margin: 10 }}>No plugins match your search.</p>
<p style={{ margin: 10 }}>No apps match your search.</p>
)}
</>
) : null}
Expand Down
14 changes: 7 additions & 7 deletions frontend/src/scenes/plugins/tabs/installed/sections/EnabledPluginsSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,15 +108,15 @@ export function EnabledPluginSection(): JSX.Element {
<Tooltip
title={
enabledPlugins.length <= 1 ? (
'At least two plugins need to be enabled for reordering.'
'At least two apps need to be enabled for reordering.'
) : (
<>
{!!searchTerm ? (
'Editing the order of plugins is disabled when searching.'
'Editing the order of apps is disabled when searching.'
) : (
<>
Order matters because event processing with plugins works like a pipe: the event is
processed by every enabled plugin <b>in sequence</b>.
Order matters because event processing with apps works like a pipe: the event is
processed by every enabled app <b>in sequence</b>.
</>
)}
</>
Expand Down Expand Up @@ -167,7 +167,7 @@ export function EnabledPluginSection(): JSX.Element {
subtitle={
<>
{sectionsOpen.includes(PluginSection.Enabled) ? <CaretDownOutlined /> : <CaretRightOutlined />}
{` Enabled plugins (${filteredEnabledPlugins.length})`}
{` Enabled apps (${filteredEnabledPlugins.length})`}
{rearranging && sectionsOpen.includes(PluginSection.Enabled) && (
<Tag color="red" style={{ fontWeight: 'normal', marginLeft: 10 }}>
Reordering in progress
Expand All @@ -184,7 +184,7 @@ export function EnabledPluginSection(): JSX.Element {
return (
<>
<EnabledPluginsHeader />
{sectionsOpen.includes(PluginSection.Enabled) && <p style={{ margin: 10 }}>No plugins enabled.</p>}
{sectionsOpen.includes(PluginSection.Enabled) && <p style={{ margin: 10 }}>No apps enabled.</p>}
</>
)
}
Expand All @@ -195,7 +195,7 @@ export function EnabledPluginSection(): JSX.Element {
{sectionsOpen.includes(PluginSection.Enabled) && (
<>
{sortableEnabledPlugins.length === 0 && unsortableEnabledPlugins.length === 0 && (
<p style={{ margin: 10 }}>No plugins match your search.</p>
<p style={{ margin: 10 }}>No apps match your search.</p>
)}
{canRearrange || rearranging ? (
<>
Expand Down
8 changes: 4 additions & 4 deletions frontend/src/scenes/plugins/tabs/installed/sections/PluginsEmptyState.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export function PluginsEmptyState(): JSX.Element {
subtitle={
<>
{' '}
<CaretRightOutlined /> {'Enabled plugins'}{' '}
<CaretRightOutlined /> {'Enabled apps'}{' '}
</>
}
buttons={<Skeleton.Button style={{ width: 150 }} />}
Expand All @@ -31,13 +31,13 @@ export function PluginsEmptyState(): JSX.Element {
</>
) : (
<>
<Subtitle subtitle="Installed plugins" />
<Subtitle subtitle="Installed apps" />
<Row gutter={16} style={{ marginTop: 16 }}>
<Col span={24}>
<Empty description={<span>You haven't installed any plugins yet</span>}>
<Empty description={<span>You haven't installed any apps yet</span>}>
{canGloballyManagePlugins(user?.organization) && (
<Button type="default" onClick={() => setPluginTab(PluginTab.Repository)}>
Open the Plugin Repository
Open the App Repository
</Button>
)}
</Empty>
Expand Down
Loading