Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Array 1.43.0 #5025

Merged
merged 39 commits into from
Jan 16, 2023
Merged

Array 1.43.0 #5025

merged 39 commits into from
Jan 16, 2023

Conversation

joethreepwood
Copy link
Contributor

Changes

Draft of new array blog post, ft. @macobo and @benjackwhite

In order to meet deadlines for @corywatilo to shoot video, we must lock content down by Thursday 13th Jan, for publishing on Monday 16th Jan.

Checklist

  • Titles are in sentence case
  • Feature names are in sentence case too
  • Words are spelled using American English
  • I have checked out our style guide

@vercel
Copy link

vercel bot commented Jan 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
posthog ✅ Ready (Inspect) Visit Preview Jan 16, 2023 at 0:11AM (UTC)

@benjackwhite
Copy link
Contributor

"highlight" PRs:

BW: Main highlights seems to be performance improvements, ARM support, FF Variant overrides

chore(flags): Remove flag for variant overrides highlight ⭐Release highlight
chore(CD): rename and consolidate container build workflows highlight ⭐Release highlight
fix: make my_last_viewed_at simpler highlight ⭐Release highlight
fix(query-performance): speed up trends queries by reducing amount of data streamed between shards highlight ⭐Release highlight
feat: cancel queries on navigation-ish highlight ⭐Release highlight
fix(query-performance): Make clickhouse_lag celery metric cheap. highlight ⭐Release highlight
chore(CI/CD): build container images for ARM64 highlight ⭐Release highlight
feat(experiments): Allow editing experiment goal highlight ⭐Release highlight
feat: better insight searching highlight ⭐Release highlight
chore: use pnpm to manage dependencies (closes #12635) highlight ⭐Release highlight
fix(time-to-see-data): Reduce dashboard API payload size 2x highlight ⭐

@benjackwhite
Copy link
Contributor

benjackwhite commented Jan 10, 2023 •
edited by Twixes
Loading

Curated list of commits since the last version

@pauldambra
Copy link
Member

across PostHog/posthog#12959, PostHog/posthog#13351, and PostHog/posthog#12544 I'd say something like:

Searching by tags and descriptions is now 1,000,000%(approx) easier

@pauldambra
Copy link
Member

PostHog/posthog#13018 might be worth highlighting because periodically people ask to be able to show the legend on a pie chart on a dashboard...

You already can, but before it was so ugly that I never wanted to 😓

@joethreepwood
Copy link
Contributor Author

joethreepwood commented Jan 10, 2023 •
edited
Loading

"highlight" PRs:

BW: Main highlights seems to be performance improvements, ARM support, FF Variant overrides

chore(flags): Remove flag for variant overrides highlight ⭐Release highlight chore(CD): rename and consolidate container build workflows highlight ⭐Release highlight fix: make my_last_viewed_at simpler highlight ⭐Release highlight fix(query-performance): speed up trends queries by reducing amount of data streamed between shards highlight ⭐Release highlight feat: cancel queries on navigation-ish highlight ⭐Release highlight fix(query-performance): Make clickhouse_lag celery metric cheap. highlight ⭐Release highlight chore(CI/CD): build container images for ARM64 highlight ⭐Release highlight feat(experiments): Allow editing experiment goal highlight ⭐Release highlight feat: better insight searching highlight ⭐Release highlight chore: use pnpm to manage dependencies (closes #12635) highlight ⭐Release highlight fix(time-to-see-data): Reduce dashboard API payload size 2x highlight ⭐

Thanks Ben!

This is kinda a long list, especially if there are more which @macobo wants to add on performance-wise. Are there any here which you think are less highlight-worthy? I'd like the highlights to be quite sizable and exciting, so an uneducated guess may be that we cut it down too...

Highlights

  • fix(query-performance): speed up trends queries by reducing amount of data streamed between shards highlight ⭐Release highlight
  • feat: cancel queries on navigation-ish highlight ⭐Release highlight
  • fix(query-performance): Make clickhouse_lag celery metric cheap. highlight ⭐Release highlight
  • feat(experiments): Allow editing experiment goal highlight ⭐Release highlight
  • feat: better insight searching highlight ⭐Release highlight
  • fix(time-to-see-data): Reduce dashboard API payload size 2x highlight ⭐
  • chore(flags): Remove flag for variant overrides highlight ⭐Release highlight

Other fixes and improvements

  • chore(CD): rename and consolidate container build workflows highlight ⭐Release highlight
  • fix: make my_last_viewed_at simpler highlight ⭐Release highlight
  • chore(CI/CD): build container images for ARM64 highlight ⭐Release highlight
  • chore: use pnpm to manage dependencies (closes #12635) highlight ⭐Release highlight

Highlights would get a full description and commentary, other fixes get a single line and link to the PR.

@pauldambra
Copy link
Member

pauldambra commented Jan 10, 2023 •
edited
Loading

This is kinda a long list, especially if there are more which @macobo wants to add on performance-wise.

Is it better to have performance as one highlight?

Then we can say "here's how we approached it" -> let Karl loose

And "look at how much we achieved" -> car-salesman-patting-roof-of-car.meme

image

@joethreepwood
Copy link
Contributor Author

That'd be ideal from my perspective, but I'll defer by default to what the improvements are in Karl's mind first!

@joethreepwood joethreepwood marked this pull request as draft January 10, 2023 14:19
@joethreepwood joethreepwood marked this pull request as ready for review January 12, 2023 12:13
@joethreepwood
Copy link
Contributor Author

This should now be ready for any final reviews.

@macobo There was quite a lot of performance improvement copy, so I've edited it quite aggressively -- you may want to take a look just to Joe-proof it! 🙏

@Twixes
Copy link
Member

Twixes commented Jan 13, 2023

I also wanna add PostHog/posthog#12773 as a highlight. I checked it in the list above – I thought you Ben & Joe planned to use that list to include things in the changelog, but I can also write the note. 😅

@joethreepwood
Copy link
Contributor Author

I also wanna add PostHog/posthog#12773 as a highlight. I checked it in the list above – I thought you Ben & Joe planned to use that list to include things in the changelog, but I can also write the note. 😅

My bad! I can add and write it up in a sec

Twixes
Twixes reviewed Jan 13, 2023
View reviewed changes
Twixes
Twixes reviewed Jan 13, 2023
View reviewed changes
contents/blog/the-posthog-array-1-43-0.md Outdated
- [New: Feature flag variant overrides](#new-feature-flag-variant-overrides)
- [New: Export recordings to file](#new-export-recordings-to-file)
- [New: Better insight searching](#new-better-insight-searching)
- [New: Show event/property counts in persons modal](#new-show-eventproperty-counts-in-persons-modal)
Copy link
Member

@Twixes Twixes Jan 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't point to a paragraph yet – just to be explicit, should I write one or would you prefer to take over this @joethreepwood?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I've written one and got a gif. Something is up with this PR which is giving me grief though. Let me try to add it in again.

@joethreepwood
Copy link
Contributor Author

Right the final addition should be in. I've also added GIFs for all NEW items, and moved improvements to the end so that the focus is on new features

@corywatilo
adding YouTube video
e520798 
(on mobile, haven't previewed)
@joethreepwood
Copy link
Contributor Author

Screenshot 2023-01-16 at 11 21 35

@corywatilo Going to revert to the normal image on this btw, unless you can point me to a Figma? Artifacting is noticeable and there’s a black line on the right side

@joethreepwood joethreepwood merged commit ee5a8c5 into master Jan 16, 2023
@joethreepwood joethreepwood deleted the array-1-43-0 branch January 16, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macobo macobo macobo left review comments

@pauldambra pauldambra pauldambra left review comments

@Twixes Twixes Twixes left review comments

@neilkakkar neilkakkar neilkakkar left review comments

@liyiy liyiy liyiy left review comments

@andyvan-ph andyvan-ph andyvan-ph left review comments

@benjackwhite benjackwhite benjackwhite approved these changes

Assignees

@macobo macobo

@benjackwhite benjackwhite

@joethreepwood joethreepwood

Labels
marketing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@joethreepwood @benjackwhite @pauldambra @Twixes @macobo @neilkakkar @liyiy @andyvan-ph @corywatilo