-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pre-fill existing tags for insights, actions, event definitions, and property definitions #12544
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm.. I think tags should be global. That means, if you add a tag "marketing" for an insight, the same tag should be available when you tag actions. There's a lot of code duplication here to prevent that from being a thing.
Also, to avoid refactoring this later, I think we should use the taxonomic filter to select tags, giving us autocompletion and pagination virtually for free.
fair
Oh, I hate changing the taxonomic filter 🤣 . I think I'll split this into two steps ✂️ |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could nit on a thing here or there, but I won't 😅. Looks good to me! 👍
Problem
closes #10678
There are several pages where you can add tags to an item. But we only suggest existing tags on one of them.
Changes
Suggest tags on insight, action, event definitions, and property definition pages
Adds an API to event definitions and property definitions to allow this. There's no pagination but there are (at least for now) very few tags on these types.
property definitions
### event definitions
insights
actions
How did you test this code?
added developer tests and checked in the UI locally