Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reorg and search by description and tags #12959

Merged
merged 1 commit into from
Nov 28, 2022
Merged

chore: reorg and search by description and tags #12959

merged 1 commit into from
Nov 28, 2022

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Nov 25, 2022 •
edited
Loading

deconstructing #12753

  • Refactor to put Dashboards scene specific files in one place.
  • got excited and added searching by description and tag while I had the file open

2022-11-25 11 28 10

pauldambra
pauldambra commented Nov 25, 2022
View reviewed changes
frontend/src/scenes/dashboard/dashboards/Dashboards.tsx
</div>
<LemonDivider className="my-4" />
{dashboardsLoading || dashboards.length > 0 || searchTerm || currentTab !== DashboardsTab.All ? (
<DashboardsTable />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than extracting and (and removing their dependencies this file hasn't changed

pauldambra
pauldambra commented Nov 25, 2022
View reviewed changes
frontend/src/scenes/dashboard/dashboards/DashboardsTable.tsx
@@ -1,50 +1,34 @@
import { useActions, useValues } from 'kea'
Copy link
Member Author

@pauldambra pauldambra Nov 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub thinks this is a file rename/move. Silly GitHub 🤷

This is extracted from the moved Dashboards.tsx

@pauldambra pauldambra mentioned this pull request Nov 25, 2022
Merged
@macobo macobo merged commit 38c542c into master Nov 28, 2022
@macobo macobo deleted the chore/reorganise-dashboards branch November 28, 2022 10:16
pauldambra added a commit that referenced this pull request Nov 29, 2022
@pauldambra @mariusandra
feat: export dashboard as json (#12964)
5cd0c9e 
Problem
deconstructing #12753

stacked on top of #12959

Changes
Adds a button to UI to export dashboards as the dashboard json template

Co-authored-by: Marius Andra <marius.andra@gmail.com>
@pauldambra pauldambra mentioned this pull request Dec 15, 2022
Open
@pauldambra pauldambra added the highlight ⭐ Release highlight label Jan 10, 2023
@pauldambra pauldambra mentioned this pull request Jan 10, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macobo macobo macobo approved these changes

@mariusandra mariusandra Awaiting requested review from mariusandra

Assignees
No one assigned
Labels
highlight ⭐ Release highlight
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pauldambra @macobo