Migrates Borg Gripper to New Attack Chain, Fixes Some Bugs #28139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warriorstar-orion
suggested changes
Jan 29, 2025
Co-authored-by: warriorstar-orion <orion@snowfrost.garden> Signed-off-by: CRUNCH <143041327+Fordoxia@users.noreply.github.com>
warriorstar-orion
approved these changes
Jan 30, 2025
|
Please god merge this as quickly as possible, not being able to fix APCs or Fire Alarms or Air Alarms that get smashed by demons/biohazards/explosives is hell. |
Burzah
approved these changes
Jan 31, 2025
azulez
pushed a commit
to azulez/Paradise
that referenced
this pull request
Feb 14, 2025
…S13#28139) * Creation * Update firealarm.dm * Update firealarm.dm * Update code/game/objects/items/robot/cyborg_gripper.dm Co-authored-by: warriorstar-orion <orion@snowfrost.garden> Signed-off-by: CRUNCH <143041327+Fordoxia@users.noreply.github.com> * Update cyborg_gripper.dm --------- Signed-off-by: CRUNCH <143041327+Fordoxia@users.noreply.github.com> Co-authored-by: warriorstar-orion <orion@snowfrost.garden>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
/obj/item/gripperto the new attack chain.return)./obj/machinery/r_n_d/scientific_analyzer/item_interaction()so it returns..()if being attacked by the gripper.Why It's Good For The Game
Attack chain migration good.
Makes the gripper compatible with new attack chain.
Bug fixes good.
Testing
Became engiborg.
Assembled fire alarm*, air alarm, APC, extinguisher cabinet, defib mount, charger, and computer from components to completion.
Attacked scientific analyser with and without items held, behaviour remains the same as before migration.
Removed cell and added cell back into charger and APC.
Became mining borg.
Checked I could still grab goliath plates and armour myself with them.
Became service borg.
Checked I could still give people cigarettes
Checked I could help people up from the floor.
Petted Ian, tried to pet a juggernaut, hugged punpun.
*fire alarm required code alterations, atomised into #28136.
Declaration
Changelog
🆑
fix: Grippers can place light tiles again.
fix: Grippers can place cells into chargers and APCs again.
fix: Grippers no longer bap machines when inserting held items into them.
fix: Grippers no longer pet animals 2 times with one attack.
/:cl: