Refactor Fire Alarm item_interaction()
#28136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
lewcc
reviewed
Jan 28, 2025
Burzah
approved these changes
Feb 10, 2025
Co-authored-by: Burzah <116982774+Burzah@users.noreply.github.com> Signed-off-by: CRUNCH <143041327+Fordoxia@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Refactors
/obj/machinery/firealarm/item_interaction()for readability.Also fixes the following bugs:
Why It's Good For The Game
Better more readable code. Enabling more better code down the line.
Testing
Assembled a fire alarm from 0 to completion.
Declaration
Changelog
🆑
fix: Fire alarm now changes to unwired sprite when wires are removed.
fix: Borg grippers can add fire alarm electronics to fire alarms.
/:cl: