Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lcobucci v5+ and drop support for anything below laravel 9 #229

Closed
wants to merge 2 commits into from

Conversation

krenor
Copy link

@krenor krenor commented Feb 14, 2024

Support lcobucci/jwt ^5.0 and drop support for versions below Laravel 9

Description

Checklist:

  • I've added tests for my changes or tests are not applicable
  • I've changed documentations or changes are not required
  • I've added my changes to CHANGELOG.md

@Messhias
Copy link
Collaborator

@krenor can you solve the conflicts, please?

@mfn
Copy link
Contributor

mfn commented Feb 21, 2024

Ah, didn't see this PR.

Conflicts with #233, we should make a decision which one to merge first.

Of course I recommend mine :)

Also because the v5+ upgrade is disrupting, adding L11 support not.

@krenor
Copy link
Author

krenor commented Feb 21, 2024

@mfn Sure, since yours also targets L11. Although I don't see a reason to support Laravel Versions that are EOL.

I'd like to get Lcobucci to v5. Shall I make a separate PR based on your branch?

@mfn
Copy link
Contributor

mfn commented Feb 21, 2024

No objections, but I would like to see smaller iteration.

For example, upgrading of one library but dropping multiple versions of Laravel support does not belong into a single change.

(personally I'm also in favour dropping everything below L9 and PHP 8.1 ASAP)

@mfn mfn mentioned this pull request Mar 18, 2024
3 tasks
@mfn
Copy link
Contributor

mfn commented Mar 18, 2024

I made #238 and concentrated only on the removal parts, because there are more opportunities of stuff to do.

I suggest once my removal PR is merged, a separate one with lcobucci v5+ should be made.

@Messhias
Copy link
Collaborator

@krenor can you check out this conflicts for us?

@Messhias
Copy link
Collaborator

Messhias commented Apr 8, 2024

@krenor are you able to check it for us?

@krenor
Copy link
Author

krenor commented Apr 9, 2024

@krenor are you able to check it for us?

I will try to find time for it this week 👍

@Messhias
Copy link
Collaborator

Messhias commented May 9, 2024

@krenor are you able to check it for us?

I will try to find time for it this week 👍

Hi, how are you doing?

Can you manage some time this week to solve this? We would like to merge this feature.

@kellerjmrtn
Copy link

I am also interested in this PR after the 2.3.0 release. All other dependencies in my app support lcobucci/jwt:^5.0 except this one, so this change would allow me to update

@Messhias
Copy link
Collaborator

I am also interested in this PR after the 2.3.0 release. All other dependencies in my app support lcobucci/jwt:^5.0 except this one, so this change would allow me to update

Would you like to fix the conflicts and make this PR mergeable for us?

@kellerjmrtn kellerjmrtn mentioned this pull request May 10, 2024
3 tasks
@kellerjmrtn
Copy link

PR created here #248

@Messhias
Copy link
Collaborator

Closing in favor of PR #248

@Messhias Messhias closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants