-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support lcobucci v5+ and drop support for anything below laravel 9 #229
Conversation
@krenor can you solve the conflicts, please? |
Ah, didn't see this PR. Conflicts with #233, we should make a decision which one to merge first. Of course I recommend mine :) Also because the v5+ upgrade is disrupting, adding L11 support not. |
@mfn Sure, since yours also targets L11. Although I don't see a reason to support Laravel Versions that are EOL. I'd like to get Lcobucci to v5. Shall I make a separate PR based on your branch? |
No objections, but I would like to see smaller iteration. For example, upgrading of one library but dropping multiple versions of Laravel support does not belong into a single change. (personally I'm also in favour dropping everything below L9 and PHP 8.1 ASAP) |
I made #238 and concentrated only on the removal parts, because there are more opportunities of stuff to do. I suggest once my removal PR is merged, a separate one with lcobucci v5+ should be made. |
@krenor can you check out this conflicts for us? |
@krenor are you able to check it for us? |
I will try to find time for it this week 👍 |
Hi, how are you doing? Can you manage some time this week to solve this? We would like to merge this feature. |
I am also interested in this PR after the 2.3.0 release. All other dependencies in my app support |
Would you like to fix the conflicts and make this PR mergeable for us? |
PR created here #248 |
Closing in favor of PR #248 |
Support lcobucci/jwt ^5.0 and drop support for versions below Laravel 9
Description
Checklist:
CHANGELOG.md