Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alternative implementation of #229. Since 2.3.0 dropped support for Laravel < 10, none of the Laravel related changes in #229 are needed.
Upgrade guide can be found here. The two notables are
Removal of
Lcobucci\JWT\Signer\Ecdsa::create()
done here. This was causing failures in a few tests. Simply not calling this method and usingnew $signer()
like is done with other Signer types fixes this.Lcobucci\JWT\Builder
was updated to be@immutable
done here. This change did not seem to cause test failures but did show up in the upgrade guide. I've updated its usage in theLcobucci
provider to reassign return valuesNote: I suppose that the addition of the
Builder
return type could be a BC break if something is extending the class? I can remove that if desiredChecklist:
CHANGELOG.md