Drop support for Laravel < 10 #238
Conversation
This also means we drop PHP < 8.1, as 8.1 is the minimum. Also take the opportunity to bump other PHP versions to their latest stable release (8.3) for GHA workflows. Also removed the explicit dotenv references, don't seem to be necessary.
Not needed anymore
There was a problem hiding this comment.
There is really a lot of stuff not necessary anymore!
| "vlucas/phpdotenv": "^5.2.0", | ||
| "yoast/phpunit-polyfills": "^2.0.0" |
There was a problem hiding this comment.
Turns out these two dev deps were not needed anymore 🤷🏼
| "orchestra/testbench": "^4.18|^5.8|^6.3|^7|^8|^9|9.x-dev", | ||
| "illuminate/console": "^10|^11", | ||
| "illuminate/routing": "^10|^11", | ||
| "orchestra/testbench": "^8|^9", |
There was a problem hiding this comment.
Removed 9.x-dev for testbench, was only necessary before the Laravel 11 release
| - | ||
| message: "#^Method PHPOpenSourceSaver\\\\JWTAuth\\\\Test\\\\Stubs\\\\LaravelUserStub\\:\\:getAuthPasswordName\\(\\) should return string but return statement is missing\\.$#" | ||
| count: 1 | ||
| path: tests/Stubs/LaravelUserStub.php |
There was a problem hiding this comment.
phpstan with latest PHP 8.3 produced this; as with all errors from Stubs, added it here (i.e. there are already others in the neon file here too).
|
@Messhias before merging this, please see #236 (comment) : we should make first a release with Carbon 3 support |
No problem, I'll release everything together, I'll see this one today in the evening and merge it, only on the weekend I release something in packist. |
Agree, makes sense. Carbon 3 is only usable with Laravel 11 anyway 👍🏼 |
No problem, I already released it anyway because there might be other people who want to use this package and can't do it because of the version. Since it was already tested I didn't mind releasing it. Today I'll review this one as well. |
Description
Similar to #229 but only concentrate o the part to drop support for unsupported software.
This also means we drop PHP < 8.1, as 8.1 is the minimum, see https://laravel.com/docs/11.x/releases#support-policy , as Laravel 9 is EOL since a month:
Also cleaned up a bit:
Checklist:
CHANGELOG.md