Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the black grid fix patch for 'Tales of the Abyss' to the GameDB #6667

Closed
wants to merge 1 commit into from
Closed

Conversation

Trixarian
Copy link

Adds the patch found at https://forums.pcsx2.net/Thread-PCSX2-Widescreen-Game-Patches?pid=627849#pid627849 for Tales of the Abyss to the GameDB

Description of Changes

This adds the patch created by sergx12 to the GameDB. It corrects the black grid effect found in the Titlescreen, Opening Cutscenes, Tataroo Valley (Night), Engeve, Kaitzur Naval Port, Baticul Castle, Grand Chokmah, Keterburg and Keterburg Bay as noted with #6497

Rationale behind Changes

#6497 has been a long standing issue caused by the use of HPO (or any texture offset) in several areas within the game. Previously the way to correct it was by using a Skipdraw range like those found with #6269 and #6074. This had notable downsides like darkened areas, the introduction of a visual glitch to The Desert Oasis and causing a notable shift of the bloom effect on Native. This patch currently corrects the issue in all known areas without the downsides introduced by the use of Skipdraw.

Suggested Testing Steps

Test the game to see if any visual glitches are introduced by the use of this patch

@Mrlinkwii
Copy link
Contributor

dose the patch effect SW mode ?

@Trixarian
Copy link
Author

dose the patch effect SW mode ?

I don't believe so. I tested it on Native Resolution and in SW Mode to be sure that it had no negative effect on either

@JordanTheToaster
Copy link
Member

So if I understand this correctly this is an upscaling patch?

@Trixarian
Copy link
Author

Trixarian commented Jul 18, 2022

So if I understand this correctly this is an upscaling patch?

It's an issue that's more apparent when upscaling and using HPO to correct the ghosting, yes. I have noted that the grid pattern does exist on Native (notable area being Grand Chokmah's skybox) - it's just a lot harder to notice without the use of upscaling or any fix that uses texture offsets

Copy link
Contributor

@lightningterror lightningterror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still this will affect sw renderer, so not a good idea.

@Trixarian
Copy link
Author

Still this will affect sw renderer, so not a good idea.

How would I go about testing for any negative effects with SW mode?

So far it doesn't seem to have a negative effect on the bloom:
gs_20220718150455_Tales of the Abyss_SLUS-21386
Cutscenes (that tends to have the black grid):
gs_20220718150509_Tales of the Abyss_SLUS-21386
and areas with extra effects like snow:
gs_20220718150654_Tales of the Abyss_SLUS-21386

@DRAGONBLE3API3C3
Copy link

Still this will affect sw renderer, so not a good idea.

Is there a way to only have this fix apply to hardware mode, then? Surely we have a quarantine-esque command for game fixes, right?

@lightningterror
Copy link
Contributor

Still this will affect sw renderer, so not a good idea.

Is there a way to only have this fix apply to hardware mode, then? Surely we have a quarantine-esque command for game fixes, right?

With patches currently no.

@DRAGONBLE3API3C3
Copy link

DRAGONBLE3API3C3 commented Jul 21, 2022

Still this will affect sw renderer, so not a good idea.

Is there a way to only have this fix apply to hardware mode, then? Surely we have a quarantine-esque command for game fixes, right?

With patches currently no.

Wouldn't that mean that there would then be potentially a large amount of game fixes that can't be automatically applied, then? Maybe I'm getting a bit ahead of myself, but I do think a simple exception system for the game fixes could be a very good thing to implement. Having your emulator be plug and play is a huge boon, in my opinion. (I'd make it myself, but I'm still a noob. :( )

@Mrlinkwii
Copy link
Contributor

Wouldn't that mean that there would then be potentially a large amount of game fixes that can't be automatically applied, then?

@DRAGONBLE3API3C3
ok , patches are for core issues , not HW render issues , patches effect both HW/SW ( even if it dosent look like it )

if you want to fix HW renderer issue use a GsHWFix or an upscaling fix ( read the Gameindex documentation for options ) if none fix the issue though luck :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants