Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameDB: Adds SkipDraw ranges to 'Tales of the Abyss' #6074

Closed
wants to merge 1 commit into from
Closed

GameDB: Adds SkipDraw ranges to 'Tales of the Abyss' #6074

wants to merge 1 commit into from

Conversation

Trixarian
Copy link

Description of Changes

GameDB: Adds SkipDraw ranges to 'Tales of the Abyss'

Rationale behind Changes

This aims to correct the graphical issues introduced by the use of Upscaling and Half-Pixel Special (Texture) in Tataroo Valley, Engave, Keterburg, Keterburg bay, and outside the castle in Baticul (among others). This does introduce a minor graphical glitch in the Desert Oasis, but should be an acceptable compromise for everything else it corrects

Suggested Testing Steps

Test suggested areas for any graphical issues

This aims to correct the graphical issues introduced by the use of Upscaling and half-pixel Special (Texture) in Tataroo Valley, Engave, Keterburg, Keterburg bay, and outside the castle in Baticul. This does introduce a minor graphical glitch in the Desert Oasis, but should be an acceptable compromise for everything else it corrects
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a contribution to PCSX2

As this is your first pull request, please be aware of the contributing guidelines.

Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.

Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!

@Ryudo300
Copy link
Contributor

Ryudo300 commented May 13, 2022

Not sure if this is still an issue with current Skipdraw settings, but in the past when using Skipdraw in TotA, it caused everything in the game to become dark, forcing you to increase brightness to the max. (And as a result this also affected the GUI + Cutscenes, becoming overly bright).

@Trixarian
Copy link
Author

Not sure if this is still an issue with current Skipdraw settings, but in the past it caused everything in the game to become dark, forcing you to increase brightness to the max. (And as a result this also affected the GUI + Cutscenes, becoming overly bright).

From what I tested, it does randomly cause some areas to become darker when loaded for the first time using manual hacks. Once loaded it doesn't seem to cause any further instances for me, but may warrant more in-depth testing to be sure

@RedDevilus
Copy link
Contributor

RedDevilus commented May 13, 2022

    skipDrawStart: 100 # Fixes black line grids in skyboxes and ghosting in some instances
    skipDrawEnd: 361 # Fixes black line grids in skyboxes and ghosting in some instances

That is very aggressive
Skipdraw 1-2 is fine in normal circumstances (not saying it will help that game) but beyond that causes multiple visual issues.

@lightningterror
Copy link
Contributor

Not in favor adding these since they are upscaling issues.

@Trixarian
Copy link
Author

Trixarian commented May 13, 2022

    skipDrawStart: 100 # Fixes black line grids in skyboxes and ghosting in some instances
    skipDrawEnd: 361 # Fixes black line grids in skyboxes and ghosting in some instances

That is very aggressive Skipdraw 1-2 is fine in normal circumstances (not saying it will help that game) but beyond that causes multiple visual issues.

I tried lower values than the ones suggested on the game's wiki page, but it doesn't seem to correct the issues that this range seems to fix. It makes Engave playable without needing to drop to Native resolution and fixes some of the blur in Tataroo Valley which Half-Pixel Special (Texture) seems to introduce there. I have noted that using an end of 354 corrects the visual issue it introduces in Desert Oasis, but breaks it everywhere else

@lightningterror
Copy link
Contributor

I will close this as it's not a good idea to add skipdraw for upscaling issues, this will break native res from looking proper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants