Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For Kinects with 0000000000000000 Serial No - use Audio Serial as a fallback -- implemented, fixes #360 #393

Closed
wants to merge 2 commits into from
Closed

For Kinects with 0000000000000000 Serial No - use Audio Serial as a fallback -- implemented, fixes #360 #393

wants to merge 2 commits into from

Conversation

olzhas
Copy link

@olzhas olzhas commented May 29, 2014

For Kinects with 0000000000000000 Serial No - use Audio Serial as a fallback -- implemented, fixes #360

libusbx v1.0.12 needed.

@piedar piedar added this to the v0.5.0 milestone May 29, 2014
@piedar
Copy link
Contributor

piedar commented May 29, 2014

Nice! Looks like vanilla libusb users will need v1.0.16.

@olzhas
Copy link
Author

olzhas commented May 30, 2014

To this date, I checked the code with 4 Kinect for Windows and it worked.
I have a question, is it sufficient or I have to check it more thoroughly some how?

@piedar
Copy link
Contributor

piedar commented May 30, 2014

It looks good to me. It will go in the next release.

Just out of curiosity, is it necessary to check both hub and port?

@olzhas
Copy link
Author

olzhas commented Jun 9, 2014

Good catch, I checked if it works with hub check only, and it worked, but I will check it more and if it works fine I will remove the port verification.

@piedar
Copy link
Contributor

piedar commented Jun 9, 2014

Also, it looks like fnusb_find_connected_audio_device does something similar. Would it make sense to reuse that function for this purpose?

@piedar piedar closed this in fb2b056 Jul 19, 2014
@piedar
Copy link
Contributor

piedar commented Jul 19, 2014

Thanks for the proof of concept. I used the existing fnusb_find_connected_audio_device to simplify the implementation.

yarikoptic added a commit to yarikoptic/libfreenect that referenced this pull request Feb 14, 2015
@yarikoptic
Merge tag 'v0.5.0' into dfsg
9716fbf 
libfreenect v0.5.0 Satellite

* tag 'v0.5.0': (44 commits)
  Fix stupid comparison mistake in audio serial fallback
  Update CMakeList.txt and ebuild for v0.5.0
  c_sync: Collapse unused functions
  Configure audio support at runtime - fixes OpenKinect#372
  Use audio serial as a fallback for K4W and 1473 models that do not provide a useful camera serial (thanks @olzhas). Fixes OpenKinect#360 and resolves OpenKinect#393.
  Remove legacy keep_alive.c; now require libusb >= 1.0.18
  c_sync: Add freenect_sync_camera_to_world() (thanks @martyvona) - fixes OpenKinect#294
  Fix a crash-on-exit in the OpenNI2 driver caused by using a deleted iterator.
  Cleanup imports in examples; also fixes a micview compile error on OS X.
  Allow freenect_set_tilt_degs to take a negative angle
  Update CMakeLists.txt for v0.4.3
  win32: Fix command in examples/CMakeLists.txt
  ebuild: Improve python dependency - fixes OpenKinect#391
  Standardize indentation in fnusb_open_subdevices
  Use non-infinite timeouts for bulk tilt / led commands Reset the audio device before using it to ensure the commands can be sent correctly Fixes OpenKinect#390
  Update README.md and CMakeLists.txt for v0.4.2
  Fix fakenect not handling freenect_process_events_timeout
  FN_DEBUG: print read_register and read_cmos_register replies
  Fix cmake module include order Fix cpack user option on linux Separate cpack options for different generators and add tgz generator Add cmake config file Fixes OpenKinect#355
  wrappers/python: update freenect.c - fixes OpenKinect#326
  ...
yarikoptic added a commit to yarikoptic/libfreenect that referenced this pull request Feb 14, 2015
@yarikoptic
Merge branch 'dfsg' into debian
b8649d5 
* dfsg: (84 commits)
  Fix stupid comparison mistake in audio serial fallback
  Update CMakeList.txt and ebuild for v0.5.0
  c_sync: Collapse unused functions
  Configure audio support at runtime - fixes OpenKinect#372
  Use audio serial as a fallback for K4W and 1473 models that do not provide a useful camera serial (thanks @olzhas). Fixes OpenKinect#360 and resolves OpenKinect#393.
  Remove legacy keep_alive.c; now require libusb >= 1.0.18
  c_sync: Add freenect_sync_camera_to_world() (thanks @martyvona) - fixes OpenKinect#294
  Fix a crash-on-exit in the OpenNI2 driver caused by using a deleted iterator.
  Cleanup imports in examples; also fixes a micview compile error on OS X.
  Allow freenect_set_tilt_degs to take a negative angle
  Update CMakeLists.txt for v0.4.3
  win32: Fix command in examples/CMakeLists.txt
  ebuild: Improve python dependency - fixes OpenKinect#391
  Standardize indentation in fnusb_open_subdevices
  Use non-infinite timeouts for bulk tilt / led commands Reset the audio device before using it to ensure the commands can be sent correctly Fixes OpenKinect#390
  Update README.md and CMakeLists.txt for v0.4.2
  Fix fakenect not handling freenect_process_events_timeout
  FN_DEBUG: print read_register and read_cmos_register replies
  Fix cmake module include order Fix cpack user option on linux Separate cpack options for different generators and add tgz generator Add cmake config file Fixes OpenKinect#355
  wrappers/python: update freenect.c - fixes OpenKinect#326
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

For Kinects with 0000000000000000 Serial No - use Audio Serial as a fallback?
2 participants
@olzhas @piedar