Bugfix infinite timeout #390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce is not shutdown correctly then it will get caught in an infinite timeout on the next run. This is because the timeout value for the new set led function was set to infinite. This PR sets it to 100ms and fixes the issue. Signed-off-by: Theodore Watson <theo@openframeworks.cc> (ofTheo)
…suring the commands can be sent correctly. Signed-off-by: Theodore Watson <theo@openframeworks.cc> (ofTheo)
|
I squashed it to one commit since it's short and sweet. |
yarikoptic
added a commit
to yarikoptic/libfreenect
that referenced
this pull request
Feb 14, 2015
libfreenect v0.5.0 Satellite * tag 'v0.5.0': (44 commits) Fix stupid comparison mistake in audio serial fallback Update CMakeList.txt and ebuild for v0.5.0 c_sync: Collapse unused functions Configure audio support at runtime - fixes OpenKinect#372 Use audio serial as a fallback for K4W and 1473 models that do not provide a useful camera serial (thanks @olzhas). Fixes OpenKinect#360 and resolves OpenKinect#393. Remove legacy keep_alive.c; now require libusb >= 1.0.18 c_sync: Add freenect_sync_camera_to_world() (thanks @martyvona) - fixes OpenKinect#294 Fix a crash-on-exit in the OpenNI2 driver caused by using a deleted iterator. Cleanup imports in examples; also fixes a micview compile error on OS X. Allow freenect_set_tilt_degs to take a negative angle Update CMakeLists.txt for v0.4.3 win32: Fix command in examples/CMakeLists.txt ebuild: Improve python dependency - fixes OpenKinect#391 Standardize indentation in fnusb_open_subdevices Use non-infinite timeouts for bulk tilt / led commands Reset the audio device before using it to ensure the commands can be sent correctly Fixes OpenKinect#390 Update README.md and CMakeLists.txt for v0.4.2 Fix fakenect not handling freenect_process_events_timeout FN_DEBUG: print read_register and read_cmos_register replies Fix cmake module include order Fix cpack user option on linux Separate cpack options for different generators and add tgz generator Add cmake config file Fixes OpenKinect#355 wrappers/python: update freenect.c - fixes OpenKinect#326 ...
yarikoptic
added a commit
to yarikoptic/libfreenect
that referenced
this pull request
Feb 14, 2015
* dfsg: (84 commits) Fix stupid comparison mistake in audio serial fallback Update CMakeList.txt and ebuild for v0.5.0 c_sync: Collapse unused functions Configure audio support at runtime - fixes OpenKinect#372 Use audio serial as a fallback for K4W and 1473 models that do not provide a useful camera serial (thanks @olzhas). Fixes OpenKinect#360 and resolves OpenKinect#393. Remove legacy keep_alive.c; now require libusb >= 1.0.18 c_sync: Add freenect_sync_camera_to_world() (thanks @martyvona) - fixes OpenKinect#294 Fix a crash-on-exit in the OpenNI2 driver caused by using a deleted iterator. Cleanup imports in examples; also fixes a micview compile error on OS X. Allow freenect_set_tilt_degs to take a negative angle Update CMakeLists.txt for v0.4.3 win32: Fix command in examples/CMakeLists.txt ebuild: Improve python dependency - fixes OpenKinect#391 Standardize indentation in fnusb_open_subdevices Use non-infinite timeouts for bulk tilt / led commands Reset the audio device before using it to ensure the commands can be sent correctly Fixes OpenKinect#390 Update README.md and CMakeLists.txt for v0.4.2 Fix fakenect not handling freenect_process_events_timeout FN_DEBUG: print read_register and read_cmos_register replies Fix cmake module include order Fix cpack user option on linux Separate cpack options for different generators and add tgz generator Add cmake config file Fixes OpenKinect#355 wrappers/python: update freenect.c - fixes OpenKinect#326 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a rather critical bug with the current master.
If the device is not shutdown correctly then it will get caught in an infinite timeout on the next run. This is because the timeout value for the new 1473/k4w led function was set to infinite.
This PR sets the timeout to 100ms and also resets the audio device before using it. The latter being the main fix for the issue.
Signed-off-by: Theodore Watson theo@openframeworks.cc (ofTheo)
Related:
openframeworks/openFrameworks#2968