Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dart generate keywords #4449

Merged
merged 2 commits into from
Nov 11, 2019
Merged

Dart generate keywords #4449

merged 2 commits into from
Nov 11, 2019

Conversation

nickmeinhold
Copy link
Contributor

Potentially fixes #4448

  • a Dart program that generates a text file containing keywords for the current Dart version
  • changed the dart generator to use the dart keywords as the set of reserved words

Questions

  • project structure: I imagine there is a better place to put these files but nothing jumped out at me when I looked through
  • the list of reserved words is now missing a few of the previous reserved words (just the ones that are a keyword with an asterisk, eg. async*, yield*)
    • not sure if this is a problem, if it is maybe we should add a separate check for special characters?

PR checklist

@wing328 wing328 added this to the 4.2.1 milestone Nov 11, 2019
wing328
wing328 requested changes Nov 11, 2019
View reviewed changes
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 11bcb66 into OpenAPITools:master Nov 11, 2019
jimschubert added a commit that referenced this pull request Nov 13, 2019
@jimschubert
Merge branch 'master' into batch-ci
ba64e08 
* master:
  [csharp-netcore] Propagate raw content to the ApiException error content. (#4381)
  Remove path relative to my home dir. (#4470)
  Avoid generating uncompilable response body in Spring's API template (#2903)
  cpp-qt5-client: remove host since it is not well handled (#4429)
  [Java] Refactor webClient generator to use URI templates to capture correct metrics (#4314)
  [Java]: Client resttemplate and webclient: array parameters of type integer in path badly generated (#4379)
  Dart generate keywords (#4449)
  [core] Fix system properties being immutable (#4447)
  [Kotlin][Client] minor improvements (#4419)
  [typescript-rxjs]: Add support for nullable (#4438)
  [asciidoc] fix names of parameters (#4440)
@roxspring roxspring mentioned this pull request Nov 14, 2019
Merged
5 tasks
@wing328
Copy link
Member

wing328 commented Nov 15, 2019

@nickmeinhold thanks for the PR, which has been included in the v4.2.1 release: https://twitter.com/oas_generator/status/1195339336922759168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wing328 wing328 wing328 approved these changes

Assignees
No one assigned
Labels
Client: Dart Enhancement: General
Projects
None yet
Milestone
4.2.1
Development

Successfully merging this pull request may close these issues.

[REQ] [Dart] Use Dart SDK to generate Dart keywords for reserved words list
2 participants
@nickmeinhold @wing328